fix(generator): disable feel for result variable (#1119)

camunda · Sep 8, 2023 · 83d3ef4 · 83d3ef4
1 parent 63dff74
commit 83d3ef4
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/...template-generator/src/main/java/io/camunda/connector/generator/dsl/CommonProperties.java b/...template-generator/src/main/java/io/camunda/connector/generator/dsl/CommonProperties.java
@@ -33,7 +33,8 @@ public class CommonProperties {
           .id("resultVariable")
           .group("output")
           .label("Result Variable")
-          .description("Name of variable to store the response in");
+          .description("Name of variable to store the response in")
+          .feel(FeelMode.disabled);
 
   public static final PropertyBuilder ERROR_EXPRESSION =
       TextProperty.builder()

diff --git a/...ator/src/test/java/io/camunda/connector/generator/core/OutboundTemplateGeneratorTest.java b/...ator/src/test/java/io/camunda/connector/generator/core/OutboundTemplateGeneratorTest.java
@@ -88,6 +88,33 @@ void elementTemplateAnnotation_providesCorrectDefaultValues() {
       assertThat(template.documentationRef()).isNull();
       assertThat(template.description()).isNull();
     }
+
+    @Test
+    void resultVariableProperty() {
+      var template = generator.generate(MyConnectorFunction.MinimallyAnnotated.class);
+      var property = getPropertyByLabel("Result Variable", template);
+      assertThat(property.getType()).isEqualTo("String");
+      assertThat(property.getBinding().type()).isEqualTo("zeebe:taskHeader");
+      assertThat(property.getFeel()).isNull();
+    }
+
+    @Test
+    void resultExpressionProperty() {
+      var template = generator.generate(MyConnectorFunction.MinimallyAnnotated.class);
+      var property = getPropertyByLabel("Result Expression", template);
+      assertThat(property.getType()).isEqualTo("Text");
+      assertThat(property.getBinding().type()).isEqualTo("zeebe:taskHeader");
+      assertThat(property.getFeel()).isEqualTo(FeelMode.required);
+    }
+
+    @Test
+    void errorExpressionProperty() {
+      var template = generator.generate(MyConnectorFunction.MinimallyAnnotated.class);
+      var property = getPropertyByLabel("Error Expression", template);
+      assertThat(property.getType()).isEqualTo("Text");
+      assertThat(property.getBinding().type()).isEqualTo("zeebe:taskHeader");
+      assertThat(property.getFeel()).isEqualTo(FeelMode.required);
+    }
   }
 
   @Nested