Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing only SUPPORT-23079 #4527

Closed
wants to merge 3 commits into from
Closed

Testing only SUPPORT-23079 #4527

wants to merge 3 commits into from

Conversation

venetrius
Copy link
Member

related to #4523

@venetrius venetrius self-assigned this Aug 7, 2024
@venetrius venetrius added ci:postgresql Runs the builds for the PostgreSQL database. ci:tomcat Runs the builds for the Tomcat application server. labels Aug 8, 2024
@venetrius venetrius changed the title Testing only Testing only SUPPORT-23079 Aug 8, 2024
@@ -257,6 +258,9 @@ public <T> T getVariable(String variableName) {

VariableValue variableValue = receivedVariableMap.get(variableName);
if (variableValue != null) {
if(variableValue.getTypedValue() instanceof Executionaware) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Instead of introducing a new interface ExecutionAware, can we just check if instanceof DeferredFileValue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
Incorporated into #4594

@venetrius venetrius closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:postgresql Runs the builds for the PostgreSQL database. ci:tomcat Runs the builds for the Tomcat application server.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants