DRY up the Serializers

camsys · Jul 8, 2017 · baa42b7 · baa42b7
1 parent c6f40b0
commit baa42b7
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 59 deletions.
diff --git a/app/serializers/export/accommodation_serializer.rb b/app/serializers/export/accommodation_serializer.rb
@@ -1,24 +1,5 @@
 module Export
-  class AccommodationSerializer < ActiveModel::Serializer
-    attributes :code,
-               :phrases
-
-    def self.collection_serialize(collection)
-      ActiveModelSerializers::SerializableResource.new(collection, each_serializer: self)
-    end
-
-    def phrases
-
-      words = {}
-
-      I18n.available_locales.each do |locale|
-        #It is not a bug that note and question are the same.  In Oneclick Legacy, there is no question
-        I18n.locale = locale
-        words[locale] = {name: TranslationEngine.translate_text(object.name), note: TranslationEngine.translate_text(object.note), question: TranslationEngine.translate_text(object.note)}
-      end
-
-      words
-    end
+  class AccommodationSerializer < EligibilitySerializer
 
   end
 end
diff --git a/app/serializers/export/characteristic_serializer.rb b/app/serializers/export/characteristic_serializer.rb
@@ -1,24 +1,5 @@
 module Export
-  class CharacteristicSerializer < ActiveModel::Serializer
-    attributes :code,
-               :phrases
-
-    def self.collection_serialize(collection)
-      ActiveModelSerializers::SerializableResource.new(collection, each_serializer: self)
-    end
-
-    def phrases
-
-      words = {}
-
-      I18n.available_locales.each do |locale|
-        #It is not a bug that note and question are the same.  In Oneclick Legacy, there is no question
-        I18n.locale = locale
-        words[locale] = {name: TranslationEngine.translate_text(object.name), note: TranslationEngine.translate_text(object.note), question: TranslationEngine.translate_text(object.note)}
-      end
-
-      words
-    end
+  class CharacteristicSerializer < EligibilitySerializer
 
   end
 end
diff --git a/app/serializers/export/eligibility_serializer.rb b/app/serializers/export/eligibility_serializer.rb
@@ -0,0 +1,24 @@
+module Export
+  class EligibilitySerializer < ActiveModel::Serializer
+    attributes :code,
+               :phrases
+
+    def self.collection_serialize(collection)
+      ActiveModelSerializers::SerializableResource.new(collection, each_serializer: self)
+    end
+
+    def phrases
+
+      words = {}
+
+      I18n.available_locales.each do |locale|
+        #It is not a bug that note and question are the same.  In Oneclick Legacy, there is no question
+        I18n.locale = locale
+        words[locale] = {name: TranslationEngine.translate_text(object.name), note: TranslationEngine.translate_text(object.note), question: TranslationEngine.translate_text(object.note)}
+      end
+
+      words
+    end
+
+  end
+end
diff --git a/app/serializers/export/trip_purpose_serializer.rb b/app/serializers/export/trip_purpose_serializer.rb
@@ -1,24 +1,6 @@
 module Export
-  class TripPurposeSerializer < ActiveModel::Serializer
-    attributes :code,
-               :phrases
+  class TripPurposeSerializer < EligibilitySerializer
 
-    def self.collection_serialize(collection)
-      ActiveModelSerializers::SerializableResource.new(collection, each_serializer: self)
-    end
-
-    def phrases
-
-      words = {}
-
-      I18n.available_locales.each do |locale|
-        #It is not a bug that note and question are the same.  In Oneclick Legacy, there is no question
-        I18n.locale = locale
-        words[locale] = {name: TranslationEngine.translate_text(object.name), note: TranslationEngine.translate_text(object.note), question: TranslationEngine.translate_text(object.note)}
-      end
-
-      words
-    end
 
   end
 end