Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): use rollup's parser #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manucorporat
Copy link

No description provided.

@calvinmetcalf
Copy link
Owner

I'm getting some failed tests when I run them locally

Repository owner deleted a comment Jun 3, 2019
@schadenn
Copy link

Changing the expects like that should fix the tests - can't do it on windows though because the Snapshots seem to be having some issues with the line-endings on my machine:

const { output } = await bundle.generate({ format: 'esm' })
expect(output[0].code).toMatchSnapshot();

@paceaux
Copy link

paceaux commented Jun 10, 2024

FYI this may also resolve this particular edge-case where where the word "global", even in a comment, can cause a syntax error if the optional chain operator is used (?.) : #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants