fix(): begin using acorn provided by rollup. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, just got back from vacation, will try to take a look |
|
does this involve requring a certain version of rollup? e.g. might it be a breaking change ? |
|
To make it non-breaking this could default to the |
|
Any further thoughts on getting this updated/merged? |
vectronic
added a commit
to vectronic/rollup-plugin-node-globals
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup provides its own instance of acorn. Using the provided version of acorn will allow dynamic imports to be parsed correctly.
This pull request fixes issue #14.