Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped React Native and Expo version #4477

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kamilkedzierski
Copy link
Member

Motivation

We needed to bump the Android SDK version (see the attached screenshot for details). To accommodate this, we also had to update React Native and Expo, as the versions we were using were outdated and no longer supported.

Summary:

Version Updates:

Issues Encountered & Resolved:

  • Icons were not displaying on the web.
  • Some test cases failed.
  • Assets from the react-native-paper library were not displaying in the example project.

All issues were resolved after the updates.

Related issue

image

Test plan

I would appreciate it if the reviewer could double-check the example app to ensure that no bugs were missed during the update. 🙏

@callstack-bot
Copy link

callstack-bot commented Aug 14, 2024

Hey @kamilkedzierski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@gedu
Copy link
Contributor

gedu commented Sep 28, 2024

This looks good, I only found 2 issues.
FAB on web doesn't look good, but I think it is a known issue.
floatingActionButton_web

What I think it is from this PR, is on iOS when switching to RTL, the app restarts infinitely.

Screen.Recording.2024-09-28.at.19.52.15.mp4

Can we fix that?

example/package.json Outdated Show resolved Hide resolved
@iM-GeeKy
Copy link

This looks good, I only found 2 issues. FAB on web doesn't look good, but I think it is a known issue. floatingActionButton_web

What I think it is from this PR, is on iOS when switching to RTL, the app restarts infinitely.

Screen.Recording.2024-09-28.at.19.52.15.mp4
Can we fix that?

Here is the FAB issue for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants