-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source dimension name mapping option #687
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 95.98% 95.99% +0.01%
==========================================
Files 26 26
Lines 3981 3994 +13
Branches 837 771 -66
==========================================
+ Hits 3821 3834 +13
Misses 70 70
Partials 90 90
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there are some CHANGELOG issues.
Additionally, a small maintainability suggestion.
@irm-codebase |
@brynpickering I like
|
@sjpfenninger I'll let you cast your vote on the naming. If it's unanimous then we'll stick with |
On the side of |
Hmmm... I see the point. Looking at how the My mind was linking the command to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Feel free to refactor to rename_dims
, too!
Fixes #680
The only question I have is whether it is better described as
rename_dims
instead ofmap_dims
.Reviewer checklist