Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup names and math docs #513

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Cleanup names and math docs #513

merged 2 commits into from
Nov 7, 2023

Conversation

brynpickering
Copy link
Member

Minor renaming to be a bit clearer

Summary of changes in this pull request:

  • objective_cost_class -> objective_cost_weights
  • minmax_cost_optimisation -> min_cost_optimisation (since it is minimising in the base math)
  • fixed math doc generation. Will need to fold this into the docs so that we don't keep missing failing parts of this...

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #513 (8d6998f) into main (3779e0d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          28       28           
  Lines        3817     3817           
  Branches      877      877           
=======================================
  Hits         3558     3558           
  Misses        168      168           
  Partials       91       91           
Files Coverage Δ
src/calliope/preprocess/checks.py 85.16% <100.00%> (ø)
src/calliope/preprocess/model_run.py 91.82% <ø> (ø)

@brynpickering brynpickering merged commit f659eab into main Nov 7, 2023
9 checks passed
@brynpickering brynpickering deleted the cleanup-names-math-docs branch November 7, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants