Rip out lots of time-adjustment functionality #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old backend run stuff fails now - time to remove it all!
sjpfenninger
requested changes
Oct 30, 2023
There was a problem hiding this comment.
With regards to timeseries_data_path → time_data_path I am a bit unsure if it doesn't remove too much of the meaning, but I suppose that is likely to go away anyway with #92 to be folded into the general data_sources config
| @@ -78,8 +78,8 @@ We will discuss each of these in turn, starting with ``config``: | |||
| config: | |||
| init: | |||
| name: 'My energy model' | |||
| timeseries_data_path: 'timeseries_data' | |||
| subset_time: ['2005-01-01', '2005-01-05'] | |||
| time_data_path: 'timeseries_data' | |||
There was a problem hiding this comment.
I think we'll want to remove this entirely in favour of the generic load-from-file feature
Co-authored-by: Stefan Pfenninger <[email protected]>
Co-authored-by: Stefan Pfenninger <[email protected]>
Co-authored-by: Stefan Pfenninger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 92.72% 93.21% +0.49%
==========================================
Files 32 28 -4
Lines 4204 3817 -387
Branches 965 877 -88
==========================================
- Hits 3898 3558 -340
+ Misses 194 168 -26
+ Partials 112 91 -21
|
sjpfenninger
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes issue #356
Summary of changes in this pull request:
Reviewer checklist: