-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of transmission techs in custom math #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old backend run stuff fails now - time to remove it all!
"-" in dimension values cannot be handled by math, so removing from national scale example model node names.
sjpfenninger
requested changes
Oct 30, 2023
Co-authored-by: Stefan Pfenninger <[email protected]>
Co-authored-by: Stefan Pfenninger <[email protected]>
Co-authored-by: Stefan Pfenninger <[email protected]>
Co-authored-by: Stefan Pfenninger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 92.36% 92.42% +0.05%
==========================================
Files 32 32
Lines 4089 4120 +31
Branches 964 969 +5
==========================================
+ Hits 3777 3808 +31
Misses 197 197
Partials 115 115
|
sjpfenninger
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to reference transmission technologies by the tech name, which will grab the relevant
tech:node_to
concatenated techs.Summary of changes in this pull request:
defined
where string helper function.-
in node names, replacing with_
(will need baking into a YAML schema in due course). With-
there was a parsing issue raised if directly referencing the tech name in the where/expression string (-
is not part of the allowed string characters).Reviewer checklist: