PHP 8.1 #921
Draft
PHP 8.1 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretto36
commented
Jul 2, 2024
There was a problem hiding this comment.
@calcinai I'd love your opinion on a few things in this PR if you have the time.
We could move the method calls to magic methods which would help to clean up the code considerably.
We still just manage the getProperties function, and any basic get/set we can completely ditch and just add an @method for
See Remote/Model change (very bottom of file)
|
Got all the tests working again. Added some extras. Updated to php 8.1, added alot of return types and removed superfluous params in PHPDocs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.