Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[james] documentation #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[james] documentation #87

wants to merge 1 commit into from

Conversation

gersbach
Copy link

Summary

What does this PR contribute?

adding documentation site. Launch under the documentation folder!

Test Plan

How should the person reviewing this PR test it out? For example, what screens in the app should they go to?

Notes

(You can leave this empty if you don't have anything.)

Next Steps

Relevant Links

Online Sources

Related PRs

Screenshots and Tests

If your feature is visual, attach before/after screenshots and ensure that tests still pass

@kbrgl
Copy link
Member

kbrgl commented Apr 25, 2022

This isn't working, since you didn't commit the .gitmodules file that git creates when you add a submodule. Try doing that and ping me when you've updated the PR! 😊

@kbrgl
Copy link
Member

kbrgl commented Apr 25, 2022

Also, this commit has a change to a file src/database/firebase.js that shouldn't be committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants