-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akshay/previously searched #84
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just a few minor fixes but it looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that if I click on a Tree Card and it is already in the "Recents stack", it will add a duplicate on top. Instead, can you change "Recents" so that 1 instance of the same tree card can ever appear at the same time, so that if i click on a tree card it is brough to the top of the list.
Also getting this console warning:
we should change the imports to the ones stated in the warning
Summary
This PR adds persistent search history functionality, updates the logic of what tree cards to suggest as a search is being typed, and adds more user feedback during different stages of searching.
Test Plan
Go to the search screen, try different search values entries of searches/pressing on search cards:
Notes
Next Steps
Relevant Links
Online Sources
Related PRs
Screenshots and Tests
screen-20220413-172113_2.mp4