Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added react-hooks eslint configs and react-native-dotenv #23

Merged
merged 1 commit into from
Oct 11, 2021
Merged

added react-hooks eslint configs and react-native-dotenv #23

merged 1 commit into from
Oct 11, 2021

Conversation

mylesdomingo
Copy link
Contributor

@mylesdomingo mylesdomingo commented Oct 7, 2021 •
edited
Loading

Summary

  • fixed dotenv module resolver
  • organized eslint rules
  • added react-hooks/ rules
"react-hooks/exhaustive-deps": "warn",
"react-hooks/rules-of-hooks": "error",

Test Plan

  • ensure that firebase env variables work as intended

Online Sources

https://reactjs.org/docs/hooks-rules.html
https://www.npmjs.com/package/react-native-dotenv
zetachang/react-native-dotenv#76

CC: @mylesdomingo

@mylesdomingo
cleanup for eslint configs
25e9f7e 
- fixed dotenv module resolver
- organized eslint rules
- added react-hooks/ rules
@mylesdomingo mylesdomingo added the requires review Needs to be reviewed label Oct 7, 2021
@kennethlien kennethlien merged commit f832e73 into main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethlien kennethlien kennethlien approved these changes

Assignees
No one assigned
Labels
requires review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mylesdomingo @kennethlien