Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create release for tag #394

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Dec 22, 2023

Closes #393

This PR:

  • introduces a GitHub workflow, release.yml, that creates a release when a Git tag is pushed
  • refactors .github/workflows/docker-publish.yml to be triggered when a Git tag is pushed

@angela-tran angela-tran self-assigned this Dec 22, 2023
Copy link

github-actions bot commented Dec 22, 2023

Coverage report

This PR does not seem to contain any modification to coverable code.

@angela-tran angela-tran force-pushed the feat/create-release-for-tag branch 2 times, most recently from 535df9d to 59bd69c Compare December 22, 2023 21:56
thekaveman
thekaveman previously approved these changes Jan 4, 2024
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments. Looks good!

.github/workflows/docker-publish.yml Show resolved Hide resolved
@@ -0,0 +1,21 @@
on:
push:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some extra space here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed it in c521775

@angela-tran angela-tran merged commit f6a09b8 into dev Jan 5, 2024
6 checks passed
@angela-tran angela-tran deleted the feat/create-release-for-tag branch January 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate creation of GitHub release when Git tag is pushed with specific name
2 participants