Feat: infra pipeline tag trigger #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-tran
force-pushed
the
feat/infra-tag-trigger
branch
3 times, most recently
from
108e642
to
d1ceddf
Compare
|
Need to look at this a little closer - specifically the |
angela-tran
force-pushed
the
feat/infra-tag-trigger
branch
from
d1ceddf
to
da549aa
Compare
angela-tran
commented
Aug 31, 2023
| # service connection | ||
| environmentServiceNameAzureRM: deployer | ||
| # the plan is done as part of the apply (below), so don't bother doing it twice | ||
| condition: notIn(variables['Build.SourceBranchName'], 'dev', 'test', 'prod') |
There was a problem hiding this comment.
We no longer need a condition on the terraform plan step because it should always run.
second stage requires environment with approval check. change 'terraform plan' step to always run.
angela-tran
force-pushed
the
feat/infra-tag-trigger
branch
from
da549aa
to
3610f01
Compare
|
This is ready for review |
This was referenced Aug 31, 2023
thekaveman
previously approved these changes
Aug 31, 2023
There was a problem hiding this comment.
This looks great @angela-tran!! Huge props for making so much progress in a short amount of time 👍
thekaveman
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284
This PR makes it possible for our existing pipeline in MST's DevOps to be triggered by pushing a git tag.
The only thing not defined in code here is the Environment which needs to be created manually and configured manually.