Admin: Update admin page titles

[machikoyasuda]

closes #2381

What this PR does

• Updates all Administrator app page titles according to what's on https://miro.com/app/board/uXjVKwXyUy0=/ - check the text above the bordered page sections
• Uses Django admin variables or Django template default titles for as much as possible: https://docs.djangoproject.com/en/5.1/ref/contrib/admin/#adminsite-attributes
• Updated anywhere we could use above variables

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits
admin.py
benefits/in_person
views.py
Project Total

This report was generated by python-coverage-comment-action

[machikoyasuda]

This is not necessary here, because the {% extends "admin/login.html" %} default Django login page's title uses Log in | site_title.

[machikoyasuda]

This logged_out page extends from agency-base, and not the default Django admin log out template, so it's necessary to explicitly spell out Logged out

[angela-tran]

(can defer this suggestion)

Since we're now setting site_title, etc. on BenefitsAdminSite, I wonder if it'd make sense to make use of the title logic in base_site.html:

{% block title %}{% if subtitle %}{{ subtitle }} | {% endif %}{{ title }} | {{ site_title|default:_('Django site admin') }}{% endblock %}

The idea is we would make agency-base.html extend base_site.html instead of base.html. We'd then set subtitle and title in the context dict, which better aligns with how the default Django admin app configures its page titles, e.g. login.

The way you've implemented setting page titles in this PR works, and I know we're trying to finish this out soon, so maybe we defer using this approach for the future, if ever.

[lalver1]

This looks good! I like how the titles are organized now 👍
While testing I did notice that server_error.html and success.html, for example, did not have the title set. So I'm wondering, would we want to add title to the context for the views: reenrollment_error, retry, system_error, server_error, success. I think this would set the title for these pages since they already inherit from error-base.html or agency-base.html.

[angela-tran]

1 requested change about success / error page titles. The other 2 comments are just notes

[angela-tran]

Just wanted to note here: @lalver1 and I had thought about setting these back when he was working on #2313; we chose not to because we didn't want to affect the superuser view.

However, now that we have the spec from product for the page titles and can see more places that need this copy, I think it makes sense to go ahead and set/use these attributes.

So the note here is that the superuser view will now use this copy as well, and I think that is perfectly fine. (We'll probably make the superuser UI and transit agency staff UI look more similar at some point anyways.)

dev-benefits	this branch

[machikoyasuda]

Thanks for documenting this!

[angela-tran]

(can defer this suggestion)

Since we're now setting site_title, etc. on BenefitsAdminSite, I wonder if it'd make sense to make use of the title logic in base_site.html:

{% block title %}{% if subtitle %}{{ subtitle }} | {% endif %}{{ title }} | {{ site_title|default:_('Django site admin') }}{% endblock %}

The idea is we would make agency-base.html extend base_site.html instead of base.html. We'd then set subtitle and title in the context dict, which better aligns with how the default Django admin app configures its page titles, e.g. login.

The way you've implemented setting page titles in this PR works, and I know we're trying to finish this out soon, so maybe we defer using this approach for the future, if ever.

[machikoyasuda]

@angela-tran @lalver1 Thanks for the review.
I added code, test updates to cover all those pages I forgot (sys error, server error, re-enrollment error, retry). And I tested them!

I wanted to do the simplest fix for now, as it's the last day of the sprint. But we could make a ticket in the future to refactor like @angela-tran suggested above at a later time.

[angela-tran]

This looks great - thank you @machikoyasuda !