Refactor: introduce enrollment module #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps separate the business logic from the decision of what response to return
make minimally needed changes to keep unit tests passing. they will be refactored to separate the view logic from the business logic in a separate commit.
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
view tests collapse down into one test
view tests collapse down into one test
it would be a success scenario if it were implemented
they were essentially moved to `test_enrollment`
angela-tran
force-pushed
the
refactor/enrollment-module
branch
from
94f383a
to
13de9bc
Compare
it was easier for me to leave this until the end of all the refactoring
angela-tran
force-pushed
the
refactor/enrollment-module
branch
from
13de9bc
to
7abf4e5
Compare
Closed
lalver1
previously approved these changes
Sep 9, 2024
thekaveman
previously approved these changes
Sep 9, 2024
There was a problem hiding this comment.
This is such a clean refactor, well done 💯 🥇
I only have 2 non-blocking comments:
- It would be helpful to have some docstrings for the new
enrollhelper, since that is used by callers external to theenrollmentmodule. - It seems like the
tokenview function could also be refactored in a similar way, and re-use the sameStatusenum concept.
One or both of these can definitely be follow-ups.
angela-tran
dismissed stale reviews from thekaveman and lalver1
via
e4b4d7a
Good idea. I added that in e4b4d7a - open to any suggestions or tweaks
Yep, definitely. I think it makes sense as a follow-up PR. It is definitely needed for completeness in handling system errors and server errors, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2327
Refactors out logic from
benefits.enrollment.viewsfor calling the transit processor API out into a separate module. This will make it easier to reuse the logic for the in-person enrollment view.Uses an
Enumas the result of the enrollment attempt.Manual testing
There shouldn't be any regressions to enrollment in the Benefits app.