Chore: Admin - Add jQuery to agency base template #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
This PR does not seem to contain any modification to coverable code. |
machikoyasuda
commented
Aug 29, 2024
| <script nonce="{{ request.csp_nonce }}" | ||
| src="https://cdn.jsdelivr.net/npm/[email protected]/dist/jquery.min.js" | ||
| integrity="sha256-o88AwQnZB+VDvE9tvIXrMQaPlFFSUTR+nldQm1LuPXQ=" | ||
| crossorigin="anonymous"></script> | ||
| {% endblock extrastyle %} | ||
|
|
There was a problem hiding this comment.
@angela-tran Should I also add this line from /calitp/app/benefits/core/templates/core/base.html to pull in the recaptcha script, in this PR?
{% if request.recaptcha %}
<script nonce="{{ request.csp_nonce }}" src="{{ request.recaptcha.script_api }}"></script>
{% endif %}There was a problem hiding this comment.
I would have preferred to be able to add this to the very bottom of the <body> tag, but there isn't an easy place to override and add this.
There was a problem hiding this comment.
FWIW, I think we can ignore reCAPTCHA for this effort -- the user must have access to the Admin, and I think we can assume they are legit if they can get in and initiate an in-person flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2328
This PR adds jQuery to the
agency-basetemplate, so all Admin pages that use this template will have access to jQuery. jQuery is used inform.html- the main form base template that the app uses for all forms.