Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Medicare cardholders #2253

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Adding Medicare cardholders #2253

merged 2 commits into from
Aug 16, 2024

Conversation

indexing
Copy link
Member

  • added Medicare cardholders to supported enrollment pathways table

- added Medicare cardholders to supported enrollment pathways table
@github-actions github-actions bot added the documentation [auto] Improvements or additions to documentation label Jul 29, 2024
Copy link

github-actions bot commented Jul 29, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

@indexing indexing marked this pull request as ready for review August 16, 2024 19:14
@indexing indexing requested a review from a team as a code owner August 16, 2024 19:14
@indexing
Copy link
Member Author

For the new Medicare cardholders row, I followed the path structure of the links to other enrollment pathways from the table.
[**Medicare cardholders**](/benefits/enrollment-pathways/medicare-cardholders)

However, it seems the links for the other enrollment pathways are broken on the live page. Click low-income as an example. I get a 404. https://github.com/cal-itp/benefits/tree/main/docs

Screenshot 2024-08-16 at 1 09 44 PM

The link is [**Low-income**](/benefits/enrollment-pathways/low-income) in the code.
The link in the published documentation is
https://github.com/cal-itp/benefits/blob/main/benefits/enrollment-pathways/low-income

The relative path looks correct, but do we need to add the full URL—including the subdomain—for the link?
https://docs.calitp.org/benefits/enrollment-pathways/low-income/

@thekaveman Something is not resolving correctly in the docs file structure.

@thekaveman
Copy link
Member

thekaveman commented Aug 16, 2024

@indexing that's just how the preview site works, unfortunately. The live site is working fine: https://docs.calitp.org/benefits/#supported-enrollment-pathways

It's because the live site is all under a sub-directory of the domain, e.g. docs.calitp.org/benefits/#supported-enrollment-pathways

But the preview site is at the top-level of the domain, e.g. benefits-2253--cal-itp-previews.netlify.app/#supported-enrollment-pathways

I don't know if its worth digging into more at this point. That's a shared preview site used by many repos in Cal-ITP. We may be able to change the way links are entered in our docs to resolve correctly no matter what, that could be something to look into... but would be a big refactor.

@indexing indexing merged commit 422b95f into main Aug 16, 2024
12 checks passed
@indexing indexing deleted the indexing-medicare-dev-status branch August 16, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants