Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Cal-ITP staff login #2220

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Feat: Cal-ITP staff login #2220

merged 9 commits into from
Jul 17, 2024

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jul 15, 2024 •
edited
Loading

Closes #2198

Builds off #2214 because this PR introduces a migration; I will rebase whenever #2214 is merged in to dev. done

This PR adds a group named Cal-ITP and logic to add users listed in GOOGLE_SSO_STAFF_LIST to that group.

Screenshot

This is what the user will see upon logging in:

image

@angela-tran angela-tran self-assigned this Jul 15, 2024
@angela-tran angela-tran requested a review from a team as a code owner July 15, 2024 21:07
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) labels Jul 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  admin.py
Project Total  

This report was generated by python-coverage-comment-action

Base automatically changed from fix/2210-localfixtures-cst to main July 15, 2024 22:25
@machikoyasuda
Copy link
Member

@angela-tran #2214 is now merged and tests are passing 🎊

@angela-tran
Copy link
Member Author

Rebased onto main

@github-actions GitHub Actions
Copy link

Preview url: https://benefits-2220--cal-itp-previews.netlify.app

thekaveman
thekaveman requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small requests.

benefits/core/admin.py Outdated Show resolved Hide resolved
benefits/core/admin.py Outdated Show resolved Hide resolved
benefits/core/migrations/0013_create_calitp_group.py Outdated Show resolved Hide resolved
docs/configuration/admin-interface.md Outdated Show resolved Hide resolved
thekaveman
thekaveman approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angela-tran
Copy link
Member Author

Thanks for the review @thekaveman!

@angela-tran angela-tran merged commit 89388c7 into main Jul 17, 2024
15 checks passed
@angela-tran angela-tran deleted the feat/cal-itp-staff-login branch July 17, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Admin tool: agency configuration
Development

Successfully merging this pull request may close these issues.

Admin interface: superusers can add new users who can login and are recognized as Cal-ITP Benefits staff
3 participants
@angela-tran @machikoyasuda @thekaveman