Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CST templates #2205

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix: CST templates #2205

merged 3 commits into from
Jul 10, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 9, 2024 •
edited
Loading

Quick follow-up to #2197, part of #2189

I thought we could get away with reusing the MSTCourtesyCard class for CST's agency card, but I forgot that some of the copy comes from that form class. So this PR adds a new class for CST.

Note that in dev and test, CST Agency Card verification will use the corresponding MST Courtesy Card verification server.

Also fixed a small translation issue on the Agency Card enrollment success for CST.

@thekaveman thekaveman requested a review from a team as a code owner July 9, 2024 19:12
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. labels Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/eligibility
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman self-assigned this Jul 9, 2024
@thekaveman thekaveman mentioned this pull request Jul 9, 2024
Closed
24 tasks
lalver1
lalver1 previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it looked good 👍

@thekaveman thekaveman requested a review from lalver1 July 10, 2024 18:08
@thekaveman
Copy link
Member Author

Sorry, I added some quick unit tests for the new form.

lalver1
lalver1 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I had forgot about test_forms.py. Looks good!

@thekaveman thekaveman merged commit 0d3988e into main Jul 10, 2024
15 checks passed
@thekaveman thekaveman deleted the fix/cst branch July 10, 2024 18:37
@machikoyasuda machikoyasuda mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalver1 lalver1 lalver1 approved these changes

Assignees

@thekaveman thekaveman

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework
Projects
Digital Services
Status: Done
Milestone
Low-income rider enrollment pathway
Development

Successfully merging this pull request may close these issues.
2 participants
@thekaveman @lalver1