Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rename dev branch to main #2202

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Chore: Rename dev branch to main #2202

merged 2 commits into from
Jul 9, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Jul 5, 2024

This PR implements the first step of code changes needed to transition the benefits repository to tag-based deployments as described in #1527. The code changes are associated with:

  • GitHub workflows
  • GitHub Issues template
  • Terraform
  • References to dev in the documentation or code comments

To merge these code changes:

  • Rename the dev branch to main in the repository's settings. Renaming instead of creating a new branch avoids having to set up branch protection rules again for main.
  • Create the main environment in GitHub’s Environments settings page following the same configuration as the dev environment
    • Set AZURE_WEBAPP_PUBLISH_PROFILE
    • Set AZURE_WEBAPP_NAME
  • Merge this PR since GitHub will automatically update the base branch of this PR to main.

Notes

These may be helpful when reviewing workspace.py:

  • REASON = Build.Reason: The event that caused the build to run.
  • OTHER_SOURCE = System.PullRequest.SourceBranch: The branch that is being reviewed in a pull request.
  • INDIVIDUAL_SOURCE = Build.SourceBranchName: The name of the branch in the triggering repo the build was queued for.
  • TARGET = System.PullRequest.TargetBranch: The branch that is the target of a pull request.

@lalver1 lalver1 self-assigned this Jul 5, 2024
@lalver1 lalver1 changed the title Chore: Rename branch to Chore: Rename dev branch to main Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@github-actions github-actions bot added actions Related to GitHub Actions workflows tests Related to automated testing (unit, UI, integration, etc.) labels Jul 5, 2024
@lalver1 lalver1 force-pushed the refactor/rename-dev-to-main branch 2 times, most recently from 838ff32 to 9e93b75 Compare July 8, 2024 22:16
@lalver1 lalver1 marked this pull request as ready for review July 8, 2024 22:33
@lalver1 lalver1 requested a review from a team as a code owner July 8, 2024 22:33
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good 👍 I have just a couple of comments on a few different areas, we can talk through anything as needed at our pairing session.

.github/workflows/labeler-deploy-main.yml Outdated Show resolved Hide resolved
terraform/pipeline/workspace.py Outdated Show resolved Hide resolved
@lalver1 lalver1 force-pushed the refactor/rename-dev-to-main branch from 9e93b75 to 305aaec Compare July 9, 2024 15:23
@lalver1 lalver1 force-pushed the refactor/rename-dev-to-main branch from 305aaec to fb33b96 Compare July 9, 2024 19:20
terraform/pipeline/workspace.py Outdated Show resolved Hide resolved
@lalver1 lalver1 force-pushed the refactor/rename-dev-to-main branch from fb33b96 to 68a924c Compare July 9, 2024 19:52
@lalver1 lalver1 merged commit 06a0b3c into main Jul 9, 2024
12 checks passed
@lalver1 lalver1 deleted the refactor/rename-dev-to-main branch July 9, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants