Fix: changing languages on the enrollment success page #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
lalver1
changed the title
lalver1
force-pushed
the
fix/spanish-button-sucess
branch
4 times, most recently
from
3a01aeb
to
b9bde4b
Compare
angela-tran
previously approved these changes
Jun 24, 2024
lalver1
force-pushed
the
fix/spanish-button-sucess
branch
from
b9bde4b
to
c7088c4
Compare
lalver1
force-pushed
the
fix/spanish-button-sucess
branch
from
c7088c4
to
64e4248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2058
On the enrollment success page, the Django
set_languageredirect view was redirecting the user to the enrollment index page when the language was changed. Looking at the Django documentation, adding anextparameter in thePOSTdata and explicitly including the enrollment success page url in the context seems to be what was missing.For all other views, when changing languages, I think we don't see this behavior because the
Refererrequest header contains the address of the same view, but for the enrollment success view,Refereris/enrollment/(I think because it is called from/enrollment/initially), so using thenextparameter is required.