Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: terraform app service deployment #2123

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented May 25, 2024

@thekaveman thekaveman self-assigned this May 25, 2024
@github-actions github-actions bot added documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc. labels May 25, 2024
Copy link

github-actions bot commented May 25, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  views.py
  benefits/enrollment
  views.py 59
  benefits/oauth
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

remove outdated references to webhooks and branch tags
@thekaveman thekaveman force-pushed the refactor/terraform-appservice-deploy branch from c67a5b1 to 54a88b3 Compare May 25, 2024 01:04
@thekaveman thekaveman marked this pull request as ready for review May 25, 2024 01:06
@thekaveman thekaveman requested a review from a team as a code owner May 25, 2024 01:06
angela-tran
angela-tran previously approved these changes May 30, 2024
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

I noticed one last bit of docs to update and opened #2128, which I'm ok with being merged into this or after this.

@thekaveman thekaveman merged commit a563e7e into dev Jun 4, 2024
10 checks passed
@thekaveman thekaveman deleted the refactor/terraform-appservice-deploy branch June 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Terraform config for new deployment setup
2 participants