-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: system enrollment error - 500 error when linking #2088
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I forgot to run |
8d55183
to
cf205c1
Compare
I rebased on |
follows implementation of retry page template. CTA goes to agency index.
we always want the agency index URL to be the origin when returning this template.
fdff7c2
to
fa77a8e
Compare
Rebased on I also updated the page title in English and Spanish using the latest from the copy spreadsheet. |
fa77a8e
to
95ec106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I was able to trigger the error using the suggested code edit, and then confirmed that the Sentry and Amplitude events were sent, copy is correct, and the CTA takes the user back to the agency homepage.
Part of #2032
This PR implements the system enrollment error page template and adds error-handling to the
benefits.enrollment.views.index
function so that if a 500-level HTTP error occurs when we try to link a funding source to a group, the system enrollment error page will be shown. The CTA takes the user back to the agency index.A Sentry notification will be sent - see an example from my testing. Note: since I don't know how to cause an actual 500 error with the linking endpoint, I had to add some code locally to fake it (more details in steps for reviewing / testing).
Screenshots
Expand
Steps for reviewing / testing
To simulate a 500-level HTTP error, I added this to my
index
function:Then run through a Login.gov flow and non-Login.gov flow all the way through enrollment as normal to see the system enrollment error page.