Fix: catch grep failure so reset script doesn't die #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with -e, the script returns an error code whenever any command does so, which can cause the rest of the Dev Container setup to fail grep returns an error code when no match is found, but we don't want that to end the script in error, so test the grep return code see https://stackoverflow.com/a/49627999/453168
thekaveman
added
bug
github-actions
bot
added
the
deployment-dev
Coverage report
This PR does not seem to contain any modification to coverable code. |
angela-tran
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-e, the script returns an error code whenever any command does so, which can cause the rest of the Dev Container setup to fail.grepreturns an error code when no match is found, but we don't want that to end the script in error, so test thegrepreturn codeSee https://stackoverflow.com/a/49627999/453168