Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: enrollment with Backoffice API #1905

Merged
merged 12 commits into from
Mar 8, 2024
Merged

Refactor: enrollment with Backoffice API #1905

merged 12 commits into from
Mar 8, 2024

Commits on Feb 29, 2024

  1. refactor(enrollment): add littlepay as dependency

    @angela-tran
    angela-tran committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    971dfe9 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. refactor(enrollment): request access token using Backoffice API 

    updates unit test for view function. some fields were needed
on PaymentProcessor to represent Backoffice API config
    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6e238c3 View commit details
    Browse the repository at this point in the history

  2. refactor(enrollment): get API token before getting enrollment token 

    change test so that getting API token is entirely mocked - I was not
able to figure out how to mock the oauth object on Client
    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    08d20eb View commit details
    Browse the repository at this point in the history

  3. chore: add commented out line that is not working but should be in test

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b79b9c2 View commit details
    Browse the repository at this point in the history

  4. refactor(enrollment): implement enrollment using Backoffice API 

    add handling for known case that should be treated as a success
    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fbc3a48 View commit details
    Browse the repository at this point in the history

  5. refactor(enrollment): delete unused code and tests 

    the enrollment view tests have not been updated yet so there are some
expected failures.

they also need to be updated to add back coverage of cases that the
deleted tests used to cover, e.g. HTTP errors from API requests.

some cases from the old tests, e.g. invalid responses, do not apply with
the new code.
    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0c0ecb1 View commit details
    Browse the repository at this point in the history

  6. test(enrollment): update existing view tests to reflect Backoffice API

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a8b7b52 View commit details
    Browse the repository at this point in the history

  7. test(enrollment): add test coverage for customer already enrolled

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a3809b2 View commit details
    Browse the repository at this point in the history

  8. test(enrollment): add test coverage for non-HTTPError failure

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6c6bb80 View commit details
    Browse the repository at this point in the history

  9. refactor(model): update PaymentProcessor model and migration 

    remove Customer-API-related fields and add new Backoffice API fields
    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ed26642 View commit details
    Browse the repository at this point in the history

  10. refactor(migrations): combine migrations related to Backoffice refactor

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cdb379e View commit details
    Browse the repository at this point in the history

  11. chore: clean up / update sample .env and update sample fixtures

    @angela-tran
    angela-tran committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3bfb9e8 View commit details
    Browse the repository at this point in the history