-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: configure Azure file share backup #1886
Conversation
the vault is where backups are stored the policy defines the frequency and retention of backups these are linked to the storage account via azurerm_backup_container_storage_account
Preview url: https://benefits-1886--cal-itp-previews.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The plan that ran for this PR looks good too. Thanks for updating the docs with notes about .tfvars 👍
It looks like the
The retention policies are a little out of line with what I had expected / understood from the docs 🤔 What I intended:
What we got:
This seems fine, we could look at reducing the 5 weeks down to 1 or 2 if we really are getting "weekly" backups every weekday... I'm definitely confused by the wording. |
Closes #1816
What this PR does
I also added a quick update to our Terraform docs for getting setup with a local
terraform.tfvars
file, which is required to run e.g.terraform plan
locally.Relevant Azure docs
Relevant Terraform docs
azurerm_recovery_services_vault
azurerm_backup_container_storage_account
azurerm_backup_policy_file_share