Feat: check for existing superuser #1851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
angela-tran
commented
Jan 11, 2024
| @@ -23,7 +23,7 @@ python manage.py migrate | |||
| # check DJANGO_ADMIN = true, default to false if empty or unset | |||
|
|
|||
| if [[ ${DJANGO_ADMIN:-false} = true ]]; then | |||
| python manage.py createsuperuser --no-input | |||
| cat benefits/superuser.py | python manage.py shell | |||
There was a problem hiding this comment.
thekaveman
requested changes
Jan 11, 2024
|
|
||
| User = get_user_model() # get the currently active user model | ||
|
|
||
| username = os.environ.get("DJANGO_SUPERUSER_USERNAME") |
There was a problem hiding this comment.
If the env vars are undefined, os.environ.get(....) hides this fact and the code continues along, only blowing up later.
I think we can use os.environ[...] here since these are all required values.
| raise RuntimeError("A user already exists with DJANGO_SUPERUSER_NAME as the username") | ||
| else: | ||
| email = os.environ.get("DJANGO_SUPERUSER_EMAIL") | ||
| password = os.environ.get("DJANGO_SUPERUSER_PASSWORD") |
There was a problem hiding this comment.
Same comment about os.environ[...] for these two.
11 tasks
22 tasks
|
Closing in favor of #1856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
./bin/init.shhas already been run and then is run again withDB_RESETset tofalse, it runs into an error related to the superuser:Log snippet
This PR checks if the superuser already exists and if not, creates it using
User.create_superuser.