Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SBMTD Mobility Pass vars to Terraform #1779

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Add SBMTD Mobility Pass vars to Terraform #1779

merged 2 commits into from
Nov 16, 2023

Conversation

machikoyasuda
Copy link
Member

closes #1777

@machikoyasuda machikoyasuda self-assigned this Nov 9, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner November 9, 2023 20:39
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

thekaveman
thekaveman reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please confirm these are all added and configured in the 3 different environments (dev, test, prod Key Vaults in Azure?)

@machikoyasuda
Copy link
Member Author

Secrets status:

  • Dev: Added all new variables for SBMTD, including FrontDoor URL for SBMTD Eligibility Server (Dev), added mst-server-public-key-url. Set mobility-pass-verifier-active to True. Removed sever-public-key-url.
  • Test and Prod: Added all new variables for SBMTD, added mst-server-public-key-url, does not have FrontDoor URLs for Test/Prod envs for Eligibility Server. Set mobility-pass-verifier-active to False. Did NOT remove sever-public-key-url b/c it is still being used.

@machikoyasuda
Copy link
Member Author

@thekaveman @angela-tran Need to get this PR re-reviewed, before I can continue set up of SBMTD Mob Pass on Dev.

angela-tran
angela-tran requested changes Nov 15, 2023
View reviewed changes
terraform/app_service.tf Outdated Show resolved Hide resolved
@machikoyasuda machikoyasuda merged commit f1d9790 into dev Nov 16, 2023
8 checks passed
@machikoyasuda machikoyasuda deleted the feat/1777-sbmtd-terraform branch November 16, 2023 19:11
This was referenced Nov 16, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SBMTD Mobility Pass variables to Azure config
3 participants
@machikoyasuda @thekaveman @angela-tran