Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: version management #1729

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Chore: version management #1729

merged 2 commits into from
Sep 19, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Sep 18, 2023

Standardizing on managing the version string in the pyproject.toml across Benefits projects.

See also cal-itp/eligibility-server#325

How to review

  1. Checkout this branch
  2. Rebuild app and devcontainer without caching docker compose build --no-cache client then the same for dev
  3. Run docker compose run --entrypoint bash client to attach to a client container
  4. Confirm pip freeze shows output similar to (look for the line mentioning benefits):
$ docker compose run --entrypoint bash client
calitp@afef4102469a:~/app$ pip freeze
asgiref==3.7.2
Authlib==1.2.1
# Editable install with no version control (benefits==2023.9.1)
-e /home/calitp/app
certifi==2023.7.22
cffi==1.15.1
...
  1. Launch devcontainer
  2. Confirm all tests pass

@thekaveman thekaveman self-assigned this Sep 18, 2023
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed tests Related to automated testing (unit, UI, integration, etc.) labels Sep 18, 2023
@thekaveman thekaveman marked this pull request as ready for review September 18, 2023 22:36
@thekaveman thekaveman requested a review from a team as a code owner September 18, 2023 22:36
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: # Editable install with no version control (benefits==2023.9.1)

@angela-tran
Copy link
Member

👀

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also successfully saw

# Editable install with no version control (benefits==2023.9.1)

and saw all 276 tests pass in the devcontainer

@thekaveman thekaveman merged commit 60b6d0b into dev Sep 19, 2023
13 checks passed
@thekaveman thekaveman deleted the chore/versions branch September 19, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants