-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: version management #1729
Conversation
app code reads dynamically from installed package version
3a818ea
to
5464c84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: # Editable install with no version control (benefits==2023.9.1)
👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also successfully saw
# Editable install with no version control (benefits==2023.9.1)
and saw all 276 tests pass in the devcontainer
Standardizing on managing the version string in the
pyproject.toml
across Benefits projects.See also cal-itp/eligibility-server#325
How to review
docker compose build --no-cache client
then the same fordev
docker compose run --entrypoint bash client
to attach to a client containerpip freeze
shows output similar to (look for the line mentioningbenefits
):