Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eligibility Start: Veterans - Use Older Adult copy #1705

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Eligibility Start: Veterans - Use Older Adult copy #1705

merged 6 commits into from
Sep 6, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 6, 2023 •
edited
Loading

closes #1693

image

What this PR does

  • Copy: Use Older Adult copy for Veterans on Elig Start
  • Button: Use Older Adult Login.gov button for Veterans on Elig Start
  • Templates: Rename senior modal to login-gov modal.
  • Make sure 2 templates affected on this PR are both set to Spaces: 2 formatting.

Note: I noticed that the indentation on the Figma designs are a lot wider than it is on the app... but this ticket is just a copy ticket, so it's not going to address this discrepancy.

@machikoyasuda machikoyasuda self-assigned this Sep 6, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner September 6, 2023 00:00
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Sep 6, 2023
@machikoyasuda machikoyasuda mentioned this pull request Sep 6, 2023
Merged
@machikoyasuda
Copy link
Member Author

Ready for re-review @angela-tran @thekaveman

thekaveman
thekaveman approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@machikoyasuda machikoyasuda merged commit 2e9089d into dev Sep 6, 2023
8 checks passed
@machikoyasuda machikoyasuda deleted the feat/1693-veterans-elig-start branch September 6, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Revise explainer copy on Vet_Eligibility_Start view to guide riders to gather necessary info for Login.gov
3 participants
@machikoyasuda @thekaveman @angela-tran