Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to test #1669

Merged
merged 508 commits into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
508 commits
Select commit Hold shift + click to select a range
38f701d
chore: run makemigrations.sh with updated dependencies
angela-tran Jul 26, 2023
34af96a
chore: update copy for Littlepay section
angela-tran Jul 21, 2023
f412564
refactor(copy): reuse msgids from Littlepay help modal
angela-tran Jul 21, 2023
9cfc143
refactor(copy): use TODOs for Spanish entries
angela-tran Jul 21, 2023
7c246ff
Chore: Help copy - agency card (#1560)
angela-tran Jul 26, 2023
0de640e
chore(linter): ignore line that causes prettier bug
machikoyasuda Jul 27, 2023
2cd52ec
fix(index): add an empty span with alt text for the landing pages image
machikoyasuda Jul 27, 2023
13c307c
chore(css): remove unused variables
machikoyasuda Jul 27, 2023
199c0e9
Fix: ignore line that causes prettier bug (#1568)
machikoyasuda Jul 27, 2023
58ede9b
Fix: Add alt text to index, agency index background image (#1569)
machikoyasuda Jul 27, 2023
bc01f9c
chore: run makemessages.sh
angela-tran Jul 27, 2023
4d25738
Chore: Help copy - Littlepay (#1561)
angela-tran Jul 28, 2023
5c5a09a
chore(copy): move existing punctuation on links to outside of link
angela-tran Jul 28, 2023
cd23766
chore(copy): add punctuation to links that were missing it
angela-tran Jul 28, 2023
bde2cc0
chore(copy): add punctuation after Login.gov modal link
angela-tran Jul 28, 2023
22f13d9
chore(copy): add punctuation after modal trigger links
angela-tran Jul 31, 2023
62089e1
chore(deps-dev): bump sentry-sdk from 1.28.1 to 1.29.0
dependabot[bot] Jul 31, 2023
341f72a
chore(deps-dev): bump sentry-sdk from 1.28.1 to 1.29.0 (#1590)
thekaveman Jul 31, 2023
239a35d
Chore: punctuation for links (#1570)
angela-tran Jul 31, 2023
43c01f5
refactor(core): use landing blocks in index template
thekaveman Jul 23, 2023
8429c39
refactor(core): agencies reference an index template
thekaveman Jul 23, 2023
627f263
refactor(core): help page content to template
thekaveman Jul 23, 2023
d991ec3
refactor(core): logged out content to template
thekaveman Jul 23, 2023
eedf03f
refactor(eligibility): use context directly for confirm
thekaveman Jul 23, 2023
a44e094
refactor(enrollment): retry content to template
thekaveman Jul 23, 2023
05693b4
chore(viewmodels): remove final Page + module
thekaveman Jul 23, 2023
1aa7dcc
refactor(base): simplify spacing for page title
thekaveman Jul 23, 2023
f832703
refactor(base): remove page.headline rendering
thekaveman Jul 23, 2023
ae0c684
chore(pre-commit): autoupdate hooks
pre-commit-ci[bot] Jul 31, 2023
fd72976
fix(index/agency index): add rounded corners to mobile box
machikoyasuda Jul 31, 2023
788bb9a
chore(pre-commit): autoupdate hooks (#1592)
thekaveman Jul 31, 2023
868cfbe
Refactor: remove Page viewmodel (#1563)
thekaveman Jul 31, 2023
740f6c3
fix(help): text is 8-md-col wide. button is offset 10
machikoyasuda Jul 31, 2023
3d4152a
fix(footer): add standard letter-spacing, increase weight to 700
machikoyasuda Aug 1, 2023
5d7f77c
fix(logingov-modals): use modal-info, use standard padding between grafs
machikoyasuda Aug 1, 2023
8241fe5
fix(modals): mobile - reduce top padding, bring text up
machikoyasuda Jul 31, 2023
4256645
fix(modal): desktop modal margin/padding should add up to 32px
machikoyasuda Aug 1, 2023
9d81cb6
refactor(css): variablize
machikoyasuda Aug 1, 2023
63a351b
Index/Agency-Index: Add rounded corners to mobile box (#1594)
machikoyasuda Aug 1, 2023
9fb7677
Footer: Fix type (letter-spacing, font-weight) (#1597)
machikoyasuda Aug 1, 2023
afc5117
Fix: Desktop - Login.gov modal alignment (#1598)
machikoyasuda Aug 1, 2023
69c8f66
feat(colors): add new primary color, hover color, footer hover color,…
machikoyasuda Aug 1, 2023
f88447c
chore(deps-dev): bump sentry-sdk from 1.29.0 to 1.29.2
dependabot[bot] Aug 1, 2023
d67ce61
chore(deps-dev): bump cypress from 12.17.2 to 12.17.3 in /tests/cypress
dependabot[bot] Aug 1, 2023
e822ce9
Add new primary color, hover color, footer hover color, footer visite…
machikoyasuda Aug 1, 2023
d9f1041
chore(deps-dev): bump cypress from 12.17.2 to 12.17.3 in /tests/cypre…
thekaveman Aug 1, 2023
bd124ab
chore(deps-dev): bump sentry-sdk from 1.29.0 to 1.29.2 (#1603)
thekaveman Aug 1, 2023
a83e602
chore(deps-dev): bump django from 4.2.3 to 4.2.4
dependabot[bot] Aug 1, 2023
88f9a97
Help: Align desktop width to 8-col (#1596)
machikoyasuda Aug 1, 2023
e608212
fix(login-btn): use col-lg-4 for login.gov button + dimension fixes
machikoyasuda Aug 1, 2023
b693c3a
fix(elig-start): override entire call-to-action area
machikoyasuda Aug 1, 2023
c197104
fix(login-btn): on desktop, btn total height is 41px
machikoyasuda Aug 1, 2023
b584df8
fix(login-btn): mobile - add max-width of 310px
machikoyasuda Aug 1, 2023
a4f6b6b
chore(elig-start): delete now un-needed flex logic code
machikoyasuda Aug 2, 2023
9abd183
chore(css): remove unnecessary var, move classes by type/page
machikoyasuda Aug 2, 2023
587732b
fix(modals): fix Agency Selector mobile bug, md-lg width bug
machikoyasuda Aug 2, 2023
dd9273c
chore(css): oops undo debug mode
machikoyasuda Aug 2, 2023
862ff63
Modals: Mobile - Get alignment right (#1599)
machikoyasuda Aug 2, 2023
389e51d
chore(deps-dev): bump django from 4.2.3 to 4.2.4 (#1602)
thekaveman Aug 2, 2023
d2a47b4
feat(line-height): add heading, h4 line-height vars and use for h1-h4
machikoyasuda Aug 2, 2023
c363285
refactor(css): use h4 line-height for card, delete card lh declaration
machikoyasuda Aug 2, 2023
e155313
Fix: Login.gov button width on Tablet (#1608)
machikoyasuda Aug 2, 2023
d6de2aa
fix(middleware): don't assume language in POST
thekaveman Aug 2, 2023
8c2c90d
test(middleware): cover valid and invalid requests
thekaveman Aug 2, 2023
fd7a0d6
chore(modal): normalize modal id pattern
thekaveman Aug 2, 2023
cad603a
Chore: normalize modal ID pattern (#1612)
thekaveman Aug 3, 2023
c4b5110
Fix: language event middleware (#1611)
thekaveman Aug 3, 2023
0998a99
Fix: Line-height across the app for H1, H2, H3, H4 (#1610)
machikoyasuda Aug 3, 2023
b2defab
fix(landing): remove x padding
machikoyasuda Aug 3, 2023
d98aa07
fix(landing): increase desktop h2 padding top to 48px
machikoyasuda Aug 3, 2023
6c4f4c1
fix(landing): desktop - reduce space between h2 and btn
machikoyasuda Aug 3, 2023
d3bca9f
fix(landing): mobile - bring back mobile-only 16px padding around box
machikoyasuda Aug 3, 2023
ffbe306
feat(enrollment): agencies have their own success template
thekaveman Aug 7, 2023
4c6d156
chore: update English agency-specific copy
thekaveman Aug 7, 2023
70612f0
fix(agency-selector-modal): fix padding regression
machikoyasuda Aug 7, 2023
895d9fe
Feat: define an enrollment success template for agencies (#1620)
thekaveman Aug 7, 2023
646ed69
Agency Selector Modal: Fix padding regression (#1622)
machikoyasuda Aug 7, 2023
39e9066
Chore: update English agency-specific copy (#1621)
thekaveman Aug 7, 2023
29134b2
fix(help): h1 is centered on desktop and mobile
machikoyasuda Aug 7, 2023
eb720f8
fix(help): create and use .h3-sm class
machikoyasuda Aug 7, 2023
0cc46a8
fix(help): use pt-4 for mobile, pt-lg-8 for desktop
machikoyasuda Aug 7, 2023
b03b9a4
fix(help): mobile - lessen padding b/w grafs by 4px
machikoyasuda Aug 7, 2023
99e8d94
chore: rename class
machikoyasuda Aug 7, 2023
840ef32
chore: implement re-name
machikoyasuda Aug 7, 2023
1839379
feat(css): new body text color
machikoyasuda Aug 7, 2023
48cbb0e
chore(pre-commit): autoupdate hooks
pre-commit-ci[bot] Aug 7, 2023
91a2e2c
chore(pre-commit): autoupdate hooks (#1625)
angela-tran Aug 7, 2023
783bf90
Landing Pages: Fix text padding (#1614)
machikoyasuda Aug 7, 2023
c13715c
Styles: New body text color (#1624)
machikoyasuda Aug 8, 2023
5cafeda
Help: Mobile - Type fixes (#1623)
machikoyasuda Aug 8, 2023
dbf66c9
refactor(copy): msgid most one-line strings
thekaveman Aug 7, 2023
022fef1
refactor(copy): msgid eligibility strings
thekaveman Aug 8, 2023
1e7b142
refactor(copy): msgid enrollment strings
thekaveman Aug 8, 2023
591fa39
refactor(copy): msgid core strings
thekaveman Aug 7, 2023
23616ab
chore(help): move the FOSS text
thekaveman Aug 8, 2023
db27d68
fix: missing word
thekaveman Aug 8, 2023
86a0213
fix: quotes
thekaveman Aug 8, 2023
ac122bc
fix: remove duplicate msgstr for Get Started
thekaveman Aug 8, 2023
30268d0
chore: replace TODO alt text
thekaveman Aug 8, 2023
119f9ce
Refactor: app strings into msgid (#1626)
thekaveman Aug 8, 2023
c8c47ec
refactor(index): use modal-trigger-link for selector, add period=False
machikoyasuda Aug 8, 2023
d28c08d
refactor(elig-start): use modal-trigger-link for Login.gov, add login…
machikoyasuda Aug 8, 2023
9fdfbbc
refactor(modals): add period=True for the rest of the modals
machikoyasuda Aug 8, 2023
cd673e7
refactor(trigger): rename cssId to just ID
machikoyasuda Aug 8, 2023
f112387
chore: rename files
machikoyasuda Aug 8, 2023
c49d35f
fix: fully rename file
machikoyasuda Aug 8, 2023
8675331
fix: use the word text instead of trigger_text
machikoyasuda Aug 8, 2023
3a54e84
fix(modal-trigger): use Modal for HREF
machikoyasuda Aug 8, 2023
02fc681
Refactor: All modal triggers are now links, not buttons (#1627)
machikoyasuda Aug 8, 2023
b5498e3
fix(css): first pass @ responsive letter-spacing for h1
machikoyasuda Aug 2, 2023
67c810b
feat(css): h2 - rename p-sm to h2-sm; apply responsive letter-spacing
machikoyasuda Aug 8, 2023
333149f
chore(css): make comment clearer
machikoyasuda Aug 3, 2023
edac160
fix(agency-modal): use .h1 instead of custom font declaration
machikoyasuda Aug 8, 2023
6ea1a92
fix(css): add .h1 to font fam declaration
machikoyasuda Aug 3, 2023
8a134e6
fix(css): h1, h2 - declare font sizes responsively up front
machikoyasuda Aug 3, 2023
0044f8d
fix(css): h1, h2 - declare font sizes responsively up front
machikoyasuda Aug 8, 2023
ea037c5
fix(css): replace p-sm with h2-sm, renamed class
machikoyasuda Aug 8, 2023
b631a85
fix(css): replace p-sm with h2-sm, renamed class
machikoyasuda Aug 8, 2023
29d6f03
fix(css): add l-s for h3, h4 responsive
machikoyasuda Aug 8, 2023
fabdfcc
fix(h4): flip the 3 and 5 perc
machikoyasuda Aug 8, 2023
c47bbaa
refactor(css): card title font size/letter-spacing should come f from h4
machikoyasuda Aug 8, 2023
ce8da3b
chore: remove unused vars
machikoyasuda Aug 8, 2023
fa3c6f0
feat(css): add new body letter-spacing
machikoyasuda Aug 8, 2023
c4506ef
feat(css): footer link letter-spacing
machikoyasuda Aug 8, 2023
51976f1
feat(css): letter-spacing for buttons
machikoyasuda Aug 8, 2023
ee2c2e5
feat(css): letter-spacing for ls-base, rest of links
machikoyasuda Aug 8, 2023
540c7a3
fix: remove this for now, use from Help PR
machikoyasuda Aug 8, 2023
958baa9
fix(h2): h2 only has 1 letter-spacing percent
machikoyasuda Aug 8, 2023
7c145d8
fix(h2): add letter-spacing for h2-sm
machikoyasuda Aug 8, 2023
5163dd1
chore: omit unneeded comment
machikoyasuda Aug 8, 2023
e3975e4
fix(landing): resolve merge conflict
machikoyasuda Aug 8, 2023
cc6bb56
feat(copy): add Spanish copy
machikoyasuda Aug 9, 2023
7bff521
fix: add back issues link
machikoyasuda Aug 9, 2023
cdbec01
fix(help): correct mst cc q/a on help
machikoyasuda Aug 9, 2023
0dfae40
fix(titles): change back Overview to Information
machikoyasuda Aug 9, 2023
0932209
fix(copy): add new Page TItles
machikoyasuda Aug 9, 2023
ec94d48
fix(enrollment): fix lp link misplaced
machikoyasuda Aug 9, 2023
abc79b3
fix(copy): switch around titles
machikoyasuda Aug 9, 2023
424161b
fix(copy): fix page titles for elig/start - use Overview
machikoyasuda Aug 9, 2023
d64d52d
chore(css): remove unused .btn-link class
machikoyasuda Aug 9, 2023
7c31e8f
feat(css): add focus ring for basic link
machikoyasuda Aug 9, 2023
8f7c066
feat(css): add focus ring for basic btn
machikoyasuda Aug 9, 2023
ed873b2
feat(css): add focus ring for card
machikoyasuda Aug 9, 2023
2613607
feat(css): add focus ring for radio input
machikoyasuda Aug 9, 2023
7e8225b
feat(css): add focus ring for cc form inputs
machikoyasuda Aug 9, 2023
7b8f853
feat(css): add white focus ring for footer links
machikoyasuda Aug 9, 2023
937fc07
fix: update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 9, 2023
1362fdb
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 9, 2023
be02a6d
docs(copy): first draft of copy/translation process doc
machikoyasuda Jun 23, 2023
d01771e
docs(copy): update link
machikoyasuda Aug 9, 2023
a2f785f
docs: delete readme, move to docs section
machikoyasuda Aug 9, 2023
992486c
docs: update i18n docs to reflect new process
machikoyasuda Aug 9, 2023
b3503f7
docs: add new product/design sidebar
machikoyasuda Aug 9, 2023
a586202
docs: add line about transferring copy
machikoyasuda Aug 9, 2023
e84ac70
docs(i18n): add instructions for agency-specific copy
machikoyasuda Aug 9, 2023
ac6eb5f
fix: Update benefits/core/templates/core/base.html
machikoyasuda Aug 10, 2023
476d8fb
fix: Update benefits/core/templates/core/base.html
machikoyasuda Aug 10, 2023
d977889
fix: Update benefits/locale/en/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8e82450
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
a0db4e7
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
6ed89e7
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
91b7081
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
83eba05
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8a19a0e
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
947a439
fix: Update benefits/locale/es/LC_MESSAGES/django.po
machikoyasuda Aug 10, 2023
8e3f04c
fix(copy): fix VeteranS everywhere
machikoyasuda Aug 10, 2023
2dfb7fe
fix(copy): : Agency card overview / Descripción de la tarjeta de agencia
machikoyasuda Aug 10, 2023
d33a410
fix(sp): don't title case any buttons in Spanish
machikoyasuda Aug 10, 2023
1335e2c
fix(copy): Courtesy card -> Agency card
machikoyasuda Aug 10, 2023
3843ff5
fix(copy): We couldn't connect your card
machikoyasuda Aug 10, 2023
2eb1184
Letter-spacing (#1613)
machikoyasuda Aug 10, 2023
18ecc4e
fix(enrollment-success): remove offset
machikoyasuda Aug 10, 2023
1c5bc10
fix(landing): add 72px extra padding/margin top for Desktop
machikoyasuda Aug 10, 2023
f04c693
fix(success): make text col-7, bigger from 6
machikoyasuda Aug 10, 2023
29d1fc9
refactor: update agency selector template to use new logo dimensions
angela-tran Aug 11, 2023
2b2ee37
Refactor: agency logo width and height (#1632)
angela-tran Aug 11, 2023
25a9f4d
Spanish copy + small copy fixes (#1629)
machikoyasuda Aug 11, 2023
7b40b0d
Merge branch 'dev' into feat/1387-focus-rings
machikoyasuda Aug 11, 2023
cf65fad
Feat: Focus rings (#1633)
machikoyasuda Aug 11, 2023
f61a608
Landing Page: Desktop - Add 72px extra padding/margin top (#1641)
machikoyasuda Aug 11, 2023
603f15d
fix(css): .btn uses primaryry-color
machikoyasuda Aug 10, 2023
24950e6
fix(btn): add hover color
machikoyasuda Aug 11, 2023
f3fb13b
fix(agency-selector): use h4 instead of .card-title
machikoyasuda Aug 11, 2023
9c716ae
Enrollment Success: Desktop - Bring text/img closer together (#1640)
machikoyasuda Aug 11, 2023
fa69047
refactor(footer): first pass at Footer refactor
machikoyasuda Aug 10, 2023
4ff0f76
refactor(footer): first pass at Footer refactor
machikoyasuda Aug 11, 2023
d4d31e3
fix(footer): add translate to mobile footer privacy link
machikoyasuda Aug 10, 2023
45991ac
fix(footer): fix extra-spacing on Desktop bug, add .footer-link to al…
machikoyasuda Aug 11, 2023
457f22a
Fix: Button uses primary-color for background (#1639)
machikoyasuda Aug 11, 2023
269c3e3
fix(enrollment-index): widen header to col-lg-8, use manual <br> betw…
machikoyasuda Aug 11, 2023
97aecf3
Enrollment Index: Ensure header is always 2 lines. (#1644)
machikoyasuda Aug 11, 2023
63be611
Fix: Agency Selector h4 bug (#1649)
machikoyasuda Aug 11, 2023
e36324e
Refactor: Footer - Re-do mobile footer alignment (#1642)
machikoyasuda Aug 11, 2023
5b243aa
feat(skip-nav): first pass @ skip nav
machikoyasuda Aug 11, 2023
43258e2
chore(css): clean up unnecessary css
machikoyasuda Aug 10, 2023
035bb78
Feat: Skip Nav (#1645)
machikoyasuda Aug 14, 2023
233c318
feat(sbmtd/senior): define EligibilityType for SBMTD senior flow
angela-tran Aug 9, 2023
4f61663
feat(sbmtd/senior): define EligibilityVerifier
angela-tran Aug 9, 2023
b938d0b
feat(sbmtd/senior): define TransitAgency with placeholder templates
angela-tran Aug 9, 2023
05b808d
feat(sbmtd/senior): add SBMTD logo files
angela-tran Aug 11, 2023
1f99743
feat(sbmtd/senior): define PaymentProcessor
angela-tran Aug 14, 2023
9ac52ab
feat(sbmtd/senior): add copy and translations to templates
angela-tran Aug 14, 2023
f2043d4
feat(sbmtd/senior): add app settings pointed at Key Vault secrets
angela-tran Aug 14, 2023
ebea84f
fix: update link to internal link
machikoyasuda Aug 14, 2023
8e99c02
Document copy/translation/i18n/PO file process (#1447)
machikoyasuda Aug 15, 2023
b251c74
Feat: configure SBMTD senior flow (#1631)
angela-tran Aug 15, 2023
f08e874
fix(eligibility): unverified takes user to index
thekaveman Aug 14, 2023
739d0f3
fix(200-user-error): use index button, override text
thekaveman Aug 15, 2023
b6d8417
fix(errors): small typo in titles
thekaveman Aug 15, 2023
43e61b4
Fix: return home button (#1655)
thekaveman Aug 15, 2023
0a55722
feat(agency-modal): first pass @ new responsive design
machikoyasuda Aug 11, 2023
9af81aa
feat(modal): get the outer spacing right
machikoyasuda Aug 11, 2023
c5c0397
refactor(modal): first pass @ combining into 1 modal template
machikoyasuda Aug 11, 2023
f2870d6
fix(modal): rename file in last 2 modals
machikoyasuda Aug 11, 2023
6cb64c7
fix(modal): fix mobile class issue
machikoyasuda Aug 11, 2023
4e96b71
chore(css): eliminate unnecessary css
machikoyasuda Aug 11, 2023
1bb0235
fix(card): add border:0 above border-top for card focus ring
machikoyasuda Aug 11, 2023
5fb062b
fix(modal): first pass @ new svg for btn-close + focus ring
machikoyasuda Aug 14, 2023
139e9a3
feat(modal): btn-close - add hover color
machikoyasuda Aug 14, 2023
c5b2e1a
fix(css): remify last border-radius
machikoyasuda Aug 15, 2023
1a5af00
chore: remove unused svg
machikoyasuda Aug 15, 2023
63c451b
fix(sbmtd/senior): typo in info_url
angela-tran Aug 15, 2023
d9aed34
Agency Modal: New design + modal includes refactor (#1646)
machikoyasuda Aug 15, 2023
0b2dc06
Fix: typo in info_url for SBMTD (#1656)
angela-tran Aug 15, 2023
f02020e
fix(card): specify card focus outline offset as 0
machikoyasuda Aug 15, 2023
c38ce96
Fix: Focus ring on Card on Google Chrome (#1658)
machikoyasuda Aug 15, 2023
d4bb71f
chore(deps-dev): bump cypress from 12.17.3 to 12.17.4 in /tests/cypress
dependabot[bot] Aug 15, 2023
07fc790
chore(deps-dev): bump cypress from 12.17.3 to 12.17.4 in /tests/cypre…
thekaveman Aug 15, 2023
5068f9d
fix(skip nav): add scroll-padding-top to remove skip nav page jank
machikoyasuda Aug 15, 2023
774be89
feat(icons): remove alt tag from decorative icons
machikoyasuda Aug 15, 2023
cf99040
fix(icon): remove name validation
machikoyasuda Aug 15, 2023
dca4eb4
fix(contactless): add back alt for contactless
machikoyasuda Aug 15, 2023
daca274
chore: format
machikoyasuda Aug 15, 2023
f806add
Fix: Remove alt tag from decorative icons (#1654)
machikoyasuda Aug 15, 2023
32cad6c
fix(tests): typo in test names
thekaveman Aug 15, 2023
3b8989c
refactor(EligibilityVerifier): references form class
thekaveman Aug 15, 2023
3711239
fix(skip-nav): add comment and better number
machikoyasuda Aug 15, 2023
54dc82f
refactor(eligibility/forms): config for MST CC
thekaveman Aug 15, 2023
0b6ea04
refactor(eligibility/confirm): simpler form context
thekaveman Aug 15, 2023
cf013de
Fix: Skip Nav - Remove skip nav page jank (#1663)
machikoyasuda Aug 15, 2023
7bfe439
Refactor: eligibility forms (#1657)
thekaveman Aug 15, 2023
cdba0b8
feat(models): add support to EligibilityVerifier for being active or not
angela-tran Aug 16, 2023
28b00cf
feat: data migration reads Key Vault secrets to set verifier active flag
angela-tran Aug 16, 2023
68078ef
feat(form): EligibilityVerifierSelectionForm only shows active verifiers
angela-tran Aug 16, 2023
baa0f56
test: set test fixture object to be seen as active EligibilityVerifier
angela-tran Aug 16, 2023
34a0506
test: update test to mirror implementation in EligibilityVerifierForm
angela-tran Aug 16, 2023
02dc099
chore: have data migration set some verifiers to active
angela-tran Aug 16, 2023
b697b92
Feat: EligibilityVerifier active flag (#1665)
angela-tran Aug 16, 2023
7858641
refactor(cypress): use .contains() and real copy, instead of DOM/ID/e…
machikoyasuda Aug 16, 2023
c82b88b
Refactor Cypress helper (#1667)
machikoyasuda Aug 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ repos:
args: ["--maxkb=1500"]

- repo: https://github.com/psf/black
rev: 23.3.0
rev: 23.7.0
hooks:
- id: black
types:
- python

- repo: https://github.com/PyCQA/flake8
rev: 6.0.0
rev: 6.1.0
hooks:
- id: flake8
types:
Expand All @@ -55,12 +55,12 @@ repos:
files: .py$

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.0.0-alpha.9-for-vscode
rev: v3.0.1
hooks:
- id: prettier
types_or: [javascript, css]

- repo: https://github.com/Riverside-Healthcare/djLint
rev: v1.31.1
rev: v1.32.1
hooks:
- id: djlint-django
10 changes: 4 additions & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
{
"djlint.guessProfile": false,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"[html]": {
"editor.defaultFormatter": "monosans.djlint"
},
"[django-html]": {
"editor.defaultFormatter": "monosans.djlint"
"[django-html][html]": {
"editor.defaultFormatter": "monosans.djlint",
"djlint.enableLinting": true,
"djlint.profile": "django"
},
"files.encoding": "utf8",
"files.eol": "\n",
Expand Down
4 changes: 2 additions & 2 deletions appcontainer/nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ http {

# 404 known scraping path targets
# case-insensitive regex matches the given path fragment anywhere in the request path
location ~* /(\.?git|api|app|assets|ats|bootstrap|bower|cgi|content|credentials|docker|doc|env|example|swagger|web) {
location ~* /(\.?git|api|app|assets|ats|bootstrap|bower|cgi|content|cpanel|credentials|debug|docker|doc|env|example|jenkins|robots|swagger|web|yq) {
access_log off;
log_not_found off;
return 404;
}

# 404 known scraping file targets
# case-insensitive regex matches the given file extension anywhere in the request path
location ~* /.*\.(asp|axd|cgi|com|env|json|php|xml|ya?ml) {
location ~* /.*\.(ash|asp|axd|cgi|com|env|json|php|ping|xml|ya?ml) {
access_log off;
log_not_found off;
return 404;
Expand Down
50 changes: 42 additions & 8 deletions benefits/core/context_processors.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,37 @@
The core application: context processors for enriching request context data.
"""
from django.conf import settings
from django.urls import reverse

from . import session
from . import models, session


def _agency_context(agency):
return {
"eligibility_index_url": agency.eligibility_index_url,
"help_template": agency.help_template,
"info_url": agency.info_url,
"long_name": agency.long_name,
"phone": agency.phone,
"short_name": agency.short_name,
"slug": agency.slug,
}


def agency(request):
"""Context processor adds some information about the active agency to the request context."""
agency = session.agency(request)

if agency is None:
return {}

return {"agency": _agency_context(agency)}


def active_agencies(request):
"""Context processor adds some information about all active agencies to the request context."""
agencies = models.TransitAgency.all_active()

return {"active_agencies": [_agency_context(agency) for agency in agencies]}


def analytics(request):
Expand All @@ -18,16 +46,12 @@ def authentication(request):

if verifier:
data = {
"required": verifier.is_auth_required,
"logged_in": session.logged_in(request),
"supports_sign_out": verifier.supports_sign_out,
"sign_out_route": reverse("oauth:logout"),
}

if verifier.is_auth_required:
auth_provider = verifier.auth_provider
data["sign_in_button_label"] = auth_provider.sign_in_button_label
data["sign_out_button_label"] = auth_provider.sign_out_button_label
data["sign_out_button_template"] = verifier.auth_provider.sign_out_button_template
data["sign_out_link_template"] = verifier.auth_provider.sign_out_link_template

return {"authentication": data}
else:
Expand All @@ -37,3 +61,13 @@ def authentication(request):
def debug(request):
"""Context processor adds debug information to request context."""
return {"debug": session.context_dict(request)}


def origin(request):
"""Context processor adds session.origin to request context."""
origin = session.origin(request)

if origin:
return {"origin": origin}
else:
return {}
35 changes: 26 additions & 9 deletions benefits/core/middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@
from django.http import HttpResponse
from django.shortcuts import redirect
from django.template.response import TemplateResponse
from django.urls import reverse
from django.utils.decorators import decorator_from_middleware
from django.utils.deprecation import MiddlewareMixin
from django.views import i18n

from . import analytics, recaptcha, session, viewmodels
from . import analytics, recaptcha, session


logger = logging.getLogger(__name__)

HEALTHCHECK_PATH = "/healthcheck"
TEMPLATE_USER_ERROR = "200_user_error.html"
ROUTE_INDEX = "core:index"
TEMPLATE_USER_ERROR = "200-user-error.html"


def user_error(request):
home = viewmodels.Button.home(request)
page = viewmodels.ErrorPage.user_error(button=home)

return TemplateResponse(request, TEMPLATE_USER_ERROR, page.context_dict())
return TemplateResponse(request, TEMPLATE_USER_ERROR)


class AgencySessionRequired(MiddlewareMixin):
Expand Down Expand Up @@ -115,9 +115,12 @@ class ChangedLanguageEvent(MiddlewareMixin):

def process_view(self, request, view_func, view_args, view_kwargs):
if view_func == i18n.set_language:
new_lang = request.POST["language"]
event = analytics.ChangedLanguageEvent(request, new_lang)
analytics.send_event(event)
new_lang = request.POST.get("language")
if new_lang:
event = analytics.ChangedLanguageEvent(request, new_lang)
analytics.send_event(event)
else:
logger.warning("i18n.set_language POST without language")
return None


Expand Down Expand Up @@ -145,3 +148,17 @@ def process_request(self, request):
"site_key": settings.RECAPTCHA_SITE_KEY,
}
return None


class IndexOrAgencyIndexOrigin(MiddlewareMixin):
"""Middleware sets the session.origin to either the core:index or core:agency_index depending on agency config."""

def process_request(self, request):
if session.active_agency(request):
session.update(request, origin=session.agency(request).index_url)
else:
session.update(request, origin=reverse(ROUTE_INDEX))
return None


index_or_agencyindex_origin_decorator = decorator_from_middleware(IndexOrAgencyIndexOrigin)
44 changes: 11 additions & 33 deletions benefits/core/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Generated by Django 4.2 on 2023-06-29 18:48
# Generated by Django 4.2.4 on 2023-08-16 15:06

from django.db import migrations, models
import django.db.models.deletion
Expand All @@ -14,8 +14,8 @@ class Migration(migrations.Migration):
name="AuthProvider",
fields=[
("id", models.AutoField(primary_key=True, serialize=False)),
("sign_in_button_label", models.TextField()),
("sign_out_button_label", models.TextField(null=True)),
("sign_out_button_template", models.TextField(null=True)),
("sign_out_link_template", models.TextField(null=True)),
("client_name", models.TextField()),
("client_id", models.TextField()),
("authority", models.TextField()),
Expand All @@ -37,42 +37,17 @@ class Migration(migrations.Migration):
name="EligibilityVerifier",
fields=[
("id", models.AutoField(primary_key=True, serialize=False)),
("bullets", models.JSONField(null=True)),
("name", models.TextField()),
("active", models.BooleanField(default=False)),
("api_url", models.TextField(null=True)),
("api_auth_header", models.TextField(null=True)),
("api_auth_key", models.TextField(null=True)),
("jwe_cek_enc", models.TextField(null=True)),
("jwe_encryption_alg", models.TextField(null=True)),
("jws_signing_alg", models.TextField(null=True)),
("selection_label", models.TextField()),
("selection_label_description", models.TextField(null=True)),
("start_title", models.TextField()),
("start_headline", models.TextField()),
("start_item_heading", models.TextField()),
("start_item_details", models.TextField()),
("start_item_secondary_details", models.TextField()),
("start_help_anchor", models.TextField()),
("form_title", models.TextField(null=True)),
("form_headline", models.TextField(null=True)),
("form_blurb", models.TextField(null=True)),
("form_sub_label", models.TextField(null=True)),
("form_sub_help_text", models.TextField(null=True)),
("form_sub_placeholder", models.TextField(null=True)),
("form_sub_pattern", models.TextField(null=True)),
("form_input_mode", models.TextField(null=True)),
("form_max_length", models.PositiveSmallIntegerField(null=True)),
("form_name_label", models.TextField(null=True)),
("form_name_help_text", models.TextField(null=True)),
("form_name_placeholder", models.TextField(null=True)),
("form_name_max_length", models.PositiveSmallIntegerField(null=True)),
("unverified_title", models.TextField()),
("unverified_blurb", models.TextField()),
("eligibility_confirmed_item_heading", models.TextField(null=True)),
("eligibility_confirmed_item_details", models.TextField(null=True)),
("enrollment_success_confirm_item_details", models.TextField()),
("enrollment_success_expiry_item_heading", models.TextField(null=True)),
("enrollment_success_expiry_item_details", models.TextField(null=True)),
("selection_label_template", models.TextField()),
("start_template", models.TextField(null=True)),
("form_class", models.TextField(null=True)),
(
"auth_provider",
models.ForeignKey(null=True, on_delete=django.db.models.deletion.PROTECT, to="core.authprovider"),
Expand Down Expand Up @@ -122,7 +97,10 @@ class Migration(migrations.Migration):
("phone", models.TextField()),
("active", models.BooleanField(default=False)),
("jws_signing_alg", models.TextField()),
("eligibility_index_intro", models.TextField()),
("index_template", models.TextField()),
("eligibility_index_template", models.TextField()),
("enrollment_success_template", models.TextField()),
("help_template", models.TextField(null=True)),
("eligibility_types", models.ManyToManyField(to="core.eligibilitytype")),
("eligibility_verifiers", models.ManyToManyField(to="core.eligibilityverifier")),
(
Expand Down
Loading
Loading