-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: EligibilityVerifier active flag #1665
Conversation
01e567f
to
68078ef
Compare
Working on fixing the failing Pytests. Will look into Cypress tests after that. Side question: is anyone else not able to use VS Code's Testing integration? I'm getting this on any branch, not just this PR's:
I'm on
|
@angela-tran RE: default values -- if it makes it easier, I think we can hardcode MST options as True, like we do for their Transit Agency. For now anyway... |
Good idea. I think that'll fix the Cypress tests |
allows the Cypress tests to pass as written
@angela-tran I'm able to run tests on my VS Code. I haven't updated to 1.81.1 yet, still on 1.81.0.
|
@angela-tran I'm able to run the tests on my VS Code. I am on 1.81.1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1662
This PR adds
active
as a field toEligibilityVerifier
and updates theEligibilityVerifierSelectionForm
so that it only shows active verifiers.The
BooleanField
on the model itself defaults to false, and then is overwritten by whatever the data migration specifies if no environment variable is found.To set verifiers as active locally
In .env:
In terminal: