Refactor: eligibility forms #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
i18n
thekaveman
force-pushed
the
refactor/eligibility-forms
branch
2 times, most recently
from
80723e3
to
3544819
Compare
|
Reviewing now |
Comment on lines
+67
to
+70
| name_max_length=None, | ||
| sub_input_mode=None, | ||
| sub_max_length=None, | ||
| sub_pattern=None, |
There was a problem hiding this comment.
These deleted comments from the data file could become docstring or comments on this file to describe these:
# A regular expression used to validate the 'sub' API field before sending to this verifier
form_sub_pattern = models.TextField(null=True)
# Input mode can be "numeric", "tel", "search", etc. to override default "text" keyboard on mobile devices
form_input_mode = models.TextField(null=True)
# The maximum length accepted for the 'sub' API field before sending to this verifier
form_max_length = models.PositiveSmallIntegerField(null=True)
# The maximum length accepted for the 'name' API field before sending to this verifier
form_name_max_length = models.PositiveSmallIntegerField(null=True)There was a problem hiding this comment.
Thanks for pasting here 🙏 I'll add those.
There was a problem hiding this comment.
Ahh, typo... one more rebase incoming
machikoyasuda
previously approved these changes
Aug 15, 2023
|
👀 |
verifier instance can create an instance of its form class
thekaveman
force-pushed
the
refactor/eligibility-forms
branch
from
3544819
to
c9a2dfe
Compare
machikoyasuda
previously approved these changes
Aug 15, 2023
moves Courtesy Card config into a form class specific to this agency card
thekaveman
force-pushed
the
refactor/eligibility-forms
branch
from
c9a2dfe
to
0b6ea04
Compare
angela-tran
approved these changes
Aug 15, 2023
|
Merging based on @machikoyasuda's prior approval. Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1564
Gets us closer to #1525
What this PR does
EligibilityVerifiermodel:form_blurb,form_sub_label, etc.form_classthat holds the name of a Python form class, adds a method to create an instance of this classMSTCourtesyCardverification, moves all config there (out of migration)Testing
bin/init.sh