Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency Modal: New design #1646

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Agency Modal: New design #1646

merged 11 commits into from
Aug 15, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 11, 2023

closes #1634
closes #1601 - rem-ify all of the border-radiuses

What this PR does

image
  • Implement new Agency Modal design. 3 fits in 1 row.
  • Refactors modal and modal-info templates into 1 template.
  • Modal close button SVG
  • Modal close button focus ring padding
  • Modal close button hover color

Note: When we get the 4th agency, we'll have to edit some CSS so that only 2 agencies show up in each row. That'll just have to happen when we get there.

Spec changes

Desktop

- Image dimension changes: 148x72
- Card dimension changes: Constant static width and height of 200x178. No longer dynamic.
image

- Card inner spacing changes: Padding is now 16px. Padding on Figma is wider, but 16px is the largest padding possible for SacRT name to fit.
image

- Card outer spacing changes: Gap between buttons is 44px
image

Mobile

  • Image dimension changes: 52x36
  • Card dimension changes: Height of 73, Width is 100% of the modal width minus 16px padding on left and right.
  • Card inner spacing changes: Padding is 12px.
  • Card outer spacing changes: Gap between buttons is 16px
  • Space between the bottom of title and beginning of card row: 24px
image

Button Close X

  • #323A45 on load
  • #045B86 on hover
image image

@machikoyasuda machikoyasuda added this to the SBMTD milestone Aug 11, 2023
@machikoyasuda machikoyasuda self-assigned this Aug 11, 2023
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Aug 11, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review August 14, 2023 23:05
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 14, 2023 23:05
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks correct for 2 and 3 agencies.

And while this isn't something we'll have to worry about probably for a bit, the modal does not look correct for 4 agencies.

Since we're doing this update, what do you think about future-proofing to the design we have now?

Figma

image

This PR

image

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Aug 15, 2023

@thekaveman I wrote this up in the PR note up top:

Note: When we get the 4th agency, we'll have to edit some CSS so that only 2 agencies show up in each row. That'll just have to happen when we get there.

There is no way to write CSS Grid or Flexbox code that can allow for logic like, "When there's 3 agencies, show them in 1 row. When there's 4 agencies, go with 2 rows of 2.", which is the design we have now:

image

Once we get to 4 agencies, we have to change a few CSS Flexbox Bootstrap classes, and then add this CSS Grid code to the .card-row at the Desktop level, and keep the code the same for the Mobile:

column-gap: 44px; /* and then assign gap figures for Mobile */
row-gap: 24px; /* and then assign gap figures for Mobile */
grid-template-columns: var(--card-width) var(--card-width);

and change 2 classes (add: d-lg-grid remove flex-lg-row) to make Desktop mode CSS Grid and Mobile mode Flexbox:

class="card-row row d-flex d-lg-grid flex-column text-start text-lg-center justify-content-center"

I have it saved in my coding notes for the future :)

So it's like a really small change.

@machikoyasuda
Copy link
Member Author

Rebased dev

@thekaveman
Copy link
Member

@machikoyasuda

I wrote this up in the PR note up top

Sorry! I didn't see that.

@machikoyasuda machikoyasuda merged commit d9aed34 into dev Aug 15, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the feat/1634-agency-modal branch August 15, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agency Selector modal design changes Refactor border-radius rules in styles.css
2 participants