Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button uses primary-color for background #1639

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix: Button uses primary-color for background #1639

merged 2 commits into from
Aug 11, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 10, 2023 •
edited
Loading

fix #1635

This fix came from @srhhnry's #1582

What this PR does

  • Previously, button background color (and 2px border color of the same color) was coming from CA State Web Template. Now we're overriding the CA State Web Template and declaring it in the CSS itself.
  • Add the hover color to button as well
image

Buttons affected

  • All CTAs with blue background
  • Doesn't affect the button in disabled state

@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 10, 2023
@machikoyasuda machikoyasuda self-assigned this Aug 10, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 10, 2023 19:51
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 10, 2023
angela-tran
angela-tran previously approved these changes Aug 11, 2023
View reviewed changes
@machikoyasuda
Copy link
Member Author

@angela-tran Rebased dev / fixed conflicts

@machikoyasuda machikoyasuda merged commit 457f22a into dev Aug 11, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/from-design-qa branch August 11, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Bug: Buttons should be primary-color
2 participants
@machikoyasuda @angela-tran