Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: All modal triggers are now links, not buttons #1627

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Refactor: All modal triggers are now links, not buttons #1627

merged 8 commits into from
Aug 8, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 8, 2023 •
edited
Loading

closes #1605

What this PR does

  • Changes the last remaining 2 modal triggers to be links. This allows for Amplitude tracking.
  • Remove now un-used modal-trigger button includes
  • Makes changes modal-trigger includes:
  1. id is now modal
  2. id is now the CSS id
  3. period (boolean) - when True, append . after link. when False, skip.
  4. login (boolean) - when True, add the <span>.... necessary for the Login.gov button fallback images

Confirmed: #1526 still occurs, even after refactor.

Screenshots

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 8, 2023 21:12
@machikoyasuda machikoyasuda mentioned this pull request Aug 8, 2023
Merged
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 8, 2023
@machikoyasuda machikoyasuda marked this pull request as draft August 8, 2023 21:13
@machikoyasuda machikoyasuda self-assigned this Aug 8, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 8, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review August 8, 2023 21:25
@machikoyasuda
Copy link
Member Author

@thekaveman rebased w latest

thekaveman
thekaveman approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 👍

@machikoyasuda machikoyasuda merged commit 02fc681 into dev Aug 8, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1605-modal-triggers branch August 8, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Make all modal triggers anchor elements
2 participants
@machikoyasuda @thekaveman