Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Mobile - Type fixes #1623

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Help: Mobile - Type fixes #1623

merged 6 commits into from
Aug 8, 2023

Conversation

machikoyasuda
Copy link
Member

fix #1615

What this PR does

  1. Headline: Center the headline on mobile
  2. The questions are now 20px font size. Create and use a utility class for this.
  3. Padding: Reduce padding between question and first graf. Reduce padding between grafs. Create and use a utility class for this.
  4. No changes for Desktop mode.

Screenshots

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 7, 2023 20:57
@machikoyasuda machikoyasuda self-assigned this Aug 7, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 7, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 7, 2023
@machikoyasuda
Copy link
Member Author

Ready for review

Comment on lines +202 to +209
@media (max-width: 992px) {
/* H2: 20px, up to Small width */
.h2-sm {
font-size: var(--font-size-20px);
line-height: var(--heading-line-height);
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #1613 PR will build off of this. Fixing the Help page first with this PR will allow me to have a place to actually test #1613's responsive H2's rendering.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to get this in because it will impact #1626

@machikoyasuda machikoyasuda merged commit 5cafeda into dev Aug 8, 2023
7 checks passed
@machikoyasuda machikoyasuda deleted the fix/1615-help--type branch August 8, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help page - Mobile - alignment/font issues
2 participants