Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency Selector Modal: Fix padding regression #1622

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

machikoyasuda
Copy link
Member

fix #1618

What this PR does

  • #agency-selector ID doesn't exist anymore
  • replace with new ID, #modal--agency-selector

Screenshot

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 7, 2023 20:00
@machikoyasuda machikoyasuda self-assigned this Aug 7, 2023
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Aug 7, 2023
@machikoyasuda machikoyasuda changed the title fix(agency-selector-modal): fix padding regression Agency Selector Modal: fix padding regression Aug 7, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😳 thank you!

@thekaveman thekaveman added this to the Veterans milestone Aug 7, 2023
@machikoyasuda machikoyasuda changed the title Agency Selector Modal: fix padding regression Agency Selector Modal: Fix padding regression Aug 7, 2023
@machikoyasuda machikoyasuda merged commit 646ed69 into dev Aug 7, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1618-modal-regression branch August 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Mobile - Agency Index modal
3 participants