Fix: Add alt text to index, agency index background image #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
|
@thekaveman Decided to go with the span approach, because I couldn't figure out a more robust way to get the div to scale properly. |
thekaveman
approved these changes
Jul 27, 2023
| @@ -11,6 +11,7 @@ | |||
| <div class="box px-4 py-3"> | |||
| <h1 class="text-left p-0">{{ page.headline }}</h1> | |||
| <h2 class="p-sm pb-lg-8 pt-1 pt-lg-4 pb-4">{% translate "core.pages.landing.h2" %}</h2> | |||
| <span role="img" aria-label="{% translate "core.pages.index.alt" %}"></span> | |||
There was a problem hiding this comment.
This also has the added benefit of inlining the alt text in the most appropriate place for the user, in context with the other (primary) content on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1418
This PR takes a different approach from the previous PR - and avoids a lot of complications in new HTML, changing the debug bar, changing templates, etc.
Instead of changing the CSS structure, this PR simply adds an empty
spantag withrole="img"andaria-labelwith the alt tag, as suggested here: https://www.davidmacd.com/blog/alternate-text-for-css-background-images.html