Feat: external link icon #1540
Merged
Feat: external link icon #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses CSS keyword 'currentColor' to achieve hover and visited styles
github-actions
bot
added
i18n
|
We'll need a separate ticket to update the Help copy The screen in Figma doesn't always include a period, but when it does, the period is a part of the link: |
thekaveman
reviewed
Jul 17, 2023
benefits/static/css/styles.css
Outdated
| @@ -142,6 +142,25 @@ a:visited:not(.btn) { | |||
| color: var(--selected-color); | |||
| } | |||
|
|
|||
| [target="_blank"]::after { | |||
There was a problem hiding this comment.
I think at a minimum we want to add the element here:
Suggested change
| [target="_blank"]::after { | |
| a[target="_blank"]::after { |
Is targeting all links with _blank enough? Too much? Is it consistent practice to make external links open in new tabs?
Asking Sarah some related questions on the Figma board:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1471
Also closes #1478 , closes #1484
This PR assumes that all external links have an attribute of
target="_blank"and adds an icon after the link.Footer links
Eligibility index
Help page