-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: template and msgid naming #1533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
migrations
[auto] Review for potential model changes/needed data migrations updates
front-end
HTML/CSS/JavaScript and Django templates
back-end
Django views, sessions, middleware, models, migrations etc.
i18n
Copy: Language files or Django i18n framework
and removed
back-end
Django views, sessions, middleware, models, migrations etc.
labels
Jul 13, 2023
thekaveman
force-pushed
the
fix/naming
branch
3 times, most recently
from
July 13, 2023 23:02
87e6265
to
f9ddfec
Compare
angela-tran
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Good! I wanted to get this done and merged so we don't have to think about it anymore / keep seeing all the variations. It's going to break #1523 though so I'll work on a rebase of that after I merge. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
front-end
HTML/CSS/JavaScript and Django templates
i18n
Copy: Language files or Django i18n framework
migrations
[auto] Review for potential model changes/needed data migrations updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big rename. Closes #1518