-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Enrollment index #1502
Conversation
1fb798f
to
c1a3c31
Compare
26f3da0
to
455683f
Compare
benefits/enrollment/templates/enrollment/includes/media_item__bankcardcheck__index.html
Outdated
Show resolved
Hide resolved
fb29378
to
eb7d759
Compare
6f1d5c0
to
6103572
Compare
This is not something I think we should change in this PR or any of the subsequent copy PRs, but I wanted to note this: The Media Item parent container width looks a bit too wide now. Not sure if this is a change in Figma, copy or what. It's something we can look into at the very very very end with @srhhnry once we finish everything else first -- after all the Modal links are in, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These code changes look good to me. I'm seeing something weird with the loading_text
though. Not sure if it's just me or what might be happening there.
6103572
to
0bf9292
Compare
otherwise variable is not available
Thanks for that find @angela-tran! I think it is because the variables aren't available outside of the In 3f8017e I moved the extra translate to within the button block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Closes #1479
Closes #1480 (copy)
Does not change how the sign out button works - this was getting a little more complicated and I didn't want to block this PR any longer. Plus that may depend on what happens in #1508.