-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: verifier radio template #1489
Conversation
60231ca
to
ba1e82e
Compare
make other selection-label-related fields optional
ba1e82e
to
5941880
Compare
basically, change from using one include to verifier's include
they've been moved to each verifier's template
2abcf0d
to
4ded806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I tested out changing the includes locally:
@thekaveman Maybe on Monday we can discuss naming/folder conventions for all these includes from this PR and #1498. There's both hyphen, underscore going on now. Not necessary to change in these PRs, but something to think about in a future refactor ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming the rendered HTML for a single radio looks the same as well:
Dev
<div class="radio-input-group d-flex">
<input class="radio-input rounded-circle flex-grow-0 flex-shrink-0"
type="radio"
name="verifier"
value="4"
required=""
id="id_verifier_0">
<label for="id_verifier_0" class="radio-label">
<span class="d-block h3">I am 65 years of age or older</span>
<span class="d-block pt-1">
You must be 65 years or older. This benefit does not expire,
but you may need to renew. Using this benefit means your
new transit fare is half of the standard fare.
</span>
</label>
</div>
This PR
<div class="radio-input-group d-flex">
<input class="radio-input rounded-circle flex-grow-0 flex-shrink-0"
type="radio"
name="verifier"
value="4"
required=""
id="id_verifier_0">
<label for="id_verifier_0" class="radio-label">
<span class="d-block h3">I am 65 years of age or older</span>
<span class="d-block pt-1">
You must be 65 years or older. This benefit does not expire,
but you may need to renew. Using this benefit means your
new transit fare is half of the standard fare.
</span>
</label>
</div>
with spacing adjusted in each
Part of #1473
Refactors the
VerifierRadioSelect
to expect aselection_label_template
to be given for each verifier, and uses that to render the label and description.This is solely a code refactor and does not change the front-end result.