Skip to content

Commit

Permalink
chore(view): reduce to bare bones
Browse files Browse the repository at this point in the history
further simplify template
  • Loading branch information
thekaveman committed Jul 6, 2023
1 parent d0774df commit 6bdbacf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 64 deletions.
23 changes: 5 additions & 18 deletions benefits/eligibility/templates/eligibility/start.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,11 @@

{% block inner-content %}
<div class="col-12 col-sm-12 col-lg-10">
<h2 class="media-title p-sm">
{% if start_sub_headline %}
{% translate start_sub_headline %}
{% else %}
{% translate "eligibility.pages.start.sub_headline" %}
{% endif %}
</h2>
{% if media %}
{% include "core/includes/media-list.html" with media=media %}
{% else %}
<ul class="media-list mx-0 px-0 d-flex justify-content-center flex-column">
{% block media-list %}
{% endblock media-list %}
</ul>
{% endif %}
<h2 class="media-title p-sm">{% translate "eligibility.pages.start.sub_headline" %}</h2>
<ul class="media-list mx-0 px-0 d-flex justify-content-center flex-column">
{% block media-list %}
{% endblock media-list %}
</ul>
</div>
{% endblock inner-content %}

Expand All @@ -39,7 +29,4 @@ <h2 class="media-title p-sm">
{% endblock call-to-action-text %}

{% block call-to-action-button %}
{% for b in page.buttons %}
{% include "core/includes/button.html" with button=b %}
{% endfor %}
{% endblock call-to-action-button %}
49 changes: 3 additions & 46 deletions benefits/eligibility/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,55 +101,12 @@ def index(request, agency=None):
@decorator_from_middleware(VerifierSessionRequired)
def start(request):
"""View handler for the eligibility verification getting started screen."""
session.update(request, eligibility_types=[], origin=reverse(ROUTE_START))

verifier = session.verifier(request)
if verifier.start_template:
return TemplateResponse(request, verifier.start_template)

button = viewmodels.Button.primary(text=_("eligibility.buttons.continue"), url=reverse(ROUTE_CONFIRM))

# define the verifier-specific required item
identity_item = viewmodels.MediaItem(
icon=viewmodels.Icon("idcardcheck", pgettext("image alt text", "core.icons.idcardcheck")),
heading=_(verifier.start_item_heading),
details=_(verifier.start_item_details),
secondary_details=_(verifier.start_item_secondary_details),
)

if verifier.is_auth_required:
identity_item.bullets = [_(bullet) for bullet in verifier.bullets]

if not session.logged_in(request):
button = viewmodels.Button.login(
text=_(verifier.auth_provider.sign_in_button_label),
url=reverse(ROUTE_LOGIN),
)

# define the bank card item
bank_card_item = viewmodels.MediaItem(
icon=viewmodels.Icon("bankcardcheck", pgettext("image alt text", "core.icons.bankcardcheck")),
heading=_("eligibility.pages.start.bankcard.title"),
details=_("eligibility.pages.start.bankcard.text"),
)

media = [identity_item, bank_card_item]

page = viewmodels.Page(
title=_(verifier.start_title),
headline=_(verifier.start_headline),
button=button,
)

ctx = page.context_dict()
ctx["previous_page_button"] = viewmodels.Button.previous_page(url=reverse(ROUTE_INDEX))
ctx["media"] = media
help_page = reverse(ROUTE_HELP)
ctx["help_link"] = f"{help_page}#{verifier.start_help_anchor}"

# update origin now, after we've saved the previous page
session.update(request, eligibility_types=[], origin=reverse(ROUTE_START))
template = verifier.start_template or TEMPLATE_START

return TemplateResponse(request, TEMPLATE_START, ctx)
return TemplateResponse(request, template)


@decorator_from_middleware(AgencySessionRequired)
Expand Down

0 comments on commit 6bdbacf

Please sign in to comment.