Skip to content

Commit

Permalink
chore(senior): refactor msgid and naming
Browse files Browse the repository at this point in the history
  • Loading branch information
thekaveman committed Jul 13, 2023
1 parent 3d1c28f commit 60430df
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 24 deletions.
4 changes: 2 additions & 2 deletions benefits/core/migrations/0002_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def load_data(app, *args, **kwargs):
eligibility_type=mst_senior_type,
auth_provider=senior_auth_provider,
selection_label_template="eligibility/includes/selection-label--senior.html",
start_template="eligibility/start--login-gov.html",
start_template="eligibility/start--senior.html",
unverified_title=_("eligibility.pages.unverified.title"),
unverified_blurb=_("eligibility.pages.unverified.p[0]"),
)
Expand Down Expand Up @@ -202,7 +202,7 @@ def load_data(app, *args, **kwargs):
eligibility_type=sacrt_senior_type,
auth_provider=senior_auth_provider,
selection_label_template="eligibility/includes/selection-label--senior.html",
start_template="eligibility/start--login-gov.html",
start_template="eligibility/start--senior.html",
unverified_title=_("eligibility.pages.unverified.title"),
unverified_blurb=_("eligibility.pages.unverified.p[0]"),
)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{% extends "core/includes/icon-title.html" %}

{% block icon %}
{% translate "core.icons.sadbus" context "image alt text" as alt_i18n %}
{% include "core/includes/icon--direct-args.html" name="sadbus" alt=alt_i18n %}
{% endblock icon %}
6 changes: 6 additions & 0 deletions benefits/core/templates/core/includes/icon-title--sadbus.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{% extends "core/includes/icon-title.html" %}

{% block icon %}
{% translate "core.icons.sadbus" context "image alt text" as alt_i18n %}
{% include "core/includes/icon--direct-args.html" name="sadbus" alt=alt_i18n %}
{% endblock icon %}
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
{% load i18n %}

{% block heading %}
{% translate "eligibility.pages.start.login_gov.start_item.heading" %}
{% translate "eligibility.pages.start.senior.start_item.heading" %}
{% endblock heading %}

{% block body %}
<div class="media-body--details">
<p>
{% translate "eligibility.pages.start.login_gov.start_item.details" %}
{% translate "eligibility.pages.start.senior.start_item.details" %}
<!-- Button to trigger modal -->
<button type="button" class="modal-trigger--link" data-bs-toggle="modal" data-bs-target="#identity-verification-help">
{% translate "eligibility.pages.start.senior.help.link_text" %}
Expand All @@ -18,9 +18,9 @@
<div class="media-body--items">
<p>{% translate "eligibility.pages.start.senior.start_item.secondary_details" %}</p>
<ul>
<li>{% translate "eligibility.pages.start.login_gov.required_items[0]" %}</li>
<li>{% translate "eligibility.pages.start.login_gov.required_items[1]" %}</li>
<li>{% translate "eligibility.pages.start.login_gov.required_items[2]" %}</li>
<li>{% translate "eligibility.pages.start.senior.required_items[0]" %}</li>
<li>{% translate "eligibility.pages.start.senior.required_items[1]" %}</li>
<li>{% translate "eligibility.pages.start.senior.required_items[2]" %}</li>
</ul>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
{% load i18n %}

{% block page_title %}
{% translate "eligibility.pages.start.login_gov.title" %}&nbsp;|&nbsp;
{% translate "eligibility.pages.start.senior.title" %}&nbsp;|&nbsp;
{% endblock page_title %}

{% block headline %}
<div class="col-lg-10">
<h1>{% translate "eligibility.pages.start.login_gov.headline" %}</h1>
<h1>{% translate "eligibility.pages.start.senior.headline" %}</h1>
</div>
{% endblock headline %}

{% block media-item %}
{% include "eligibility/includes/media-item--idcardcheck--start--login-gov.html" %}
{% include "eligibility/includes/media-item--idcardcheck--start--senior.html" %}
{% endblock media-item %}

{% block call-to-action-button %}
Expand Down
14 changes: 7 additions & 7 deletions benefits/locale/en/LC_MESSAGES/django.po
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,10 @@ msgctxt "image alt text"
msgid "core.icons.idcardcheck"
msgstr "Identification card icon with checkmark"

msgid "eligibility.pages.start.login_gov.start_item.heading"
msgid "eligibility.pages.start.senior.start_item.heading"
msgstr "A Login.gov account with identity verification"

msgid "eligibility.pages.start.login_gov.start_item.details"
msgid "eligibility.pages.start.senior.start_item.details"
msgstr ""
"You will be able to create an account using your email address if you do not "
"already have one. We use your Login.gov account to verify your identity."
Expand All @@ -392,13 +392,13 @@ msgstr "Learn more about identity verification"
msgid "eligibility.pages.start.senior.start_item.secondary_details"
msgstr "For this process you will need:"

msgid "eligibility.pages.start.login_gov.required_items[0]"
msgid "eligibility.pages.start.senior.required_items[0]"
msgstr "Your state-issued ID card"

msgid "eligibility.pages.start.login_gov.required_items[1]"
msgid "eligibility.pages.start.senior.required_items[1]"
msgstr "Your Social Security number"

msgid "eligibility.pages.start.login_gov.required_items[2]"
msgid "eligibility.pages.start.senior.required_items[2]"
msgstr "A phone number with a phone plan associated with your name"

msgid "eligibility.pages.start.mst_cc.start_item.heading"
Expand Down Expand Up @@ -544,10 +544,10 @@ msgstr "Choose the transit benefit you would like to enroll in"
msgid "eligibility.pages.start.sub_headline"
msgstr "You will need a few items to continue:"

msgid "eligibility.pages.start.login_gov.title"
msgid "eligibility.pages.start.senior.title"
msgstr "Older Adult benefit information"

msgid "eligibility.pages.start.login_gov.headline"
msgid "eligibility.pages.start.senior.headline"
msgstr "You selected an Older Adult transit benefit."

msgid "eligibility.buttons.senior.signin"
Expand Down
14 changes: 7 additions & 7 deletions benefits/locale/es/LC_MESSAGES/django.po
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,10 @@ msgctxt "image alt text"
msgid "core.icons.idcardcheck"
msgstr "Icono de tarjeta de identificación con marca de verificación"

msgid "eligibility.pages.start.login_gov.start_item.heading"
msgid "eligibility.pages.start.senior.start_item.heading"
msgstr "Una cuenta de Login.gov con verificación de identidad"

msgid "eligibility.pages.start.login_gov.start_item.details"
msgid "eligibility.pages.start.senior.start_item.details"
msgstr ""
"TODO: You will be able to create an account using your email address if you "
"do not already have one. We use your Login.gov account to verify your "
Expand All @@ -404,13 +404,13 @@ msgid "eligibility.pages.start.senior.start_item.secondary_details"
msgstr ""
"TODO: For this process you will need:"

msgid "eligibility.pages.start.login_gov.required_items[0]"
msgid "eligibility.pages.start.senior.required_items[0]"
msgstr "Su tarjeta de identificación emitida por el estado"

msgid "eligibility.pages.start.login_gov.required_items[1]"
msgid "eligibility.pages.start.senior.required_items[1]"
msgstr "Su número de Seguro Social"

msgid "eligibility.pages.start.login_gov.required_items[2]"
msgid "eligibility.pages.start.senior.required_items[2]"
msgstr "Un número de teléfono con un plan de teléfono asociado con su nombre"

msgid "eligibility.pages.start.mst_cc.start_item.heading"
Expand Down Expand Up @@ -556,10 +556,10 @@ msgstr "TODO: Choose the transit benefit you would like to enroll in"
msgid "eligibility.pages.start.sub_headline"
msgstr "TODO: Necesitará algunos artículos para conectar su beneficio:"

msgid "eligibility.pages.start.login_gov.title"
msgid "eligibility.pages.start.senior.title"
msgstr "Información sobre beneficios para Adultos Mayores"

msgid "eligibility.pages.start.login_gov.headline"
msgid "eligibility.pages.start.senior.headline"
msgstr "Usted seleccionó un beneficio para Adultos Mayores"

msgid "eligibility.buttons.senior.signin"
Expand Down

0 comments on commit 60430df

Please sign in to comment.