fix(models): allow SecretNameField to be blank

since it is not a required field on many models

overriding blank=False made it so a model could not be
saved in the Admin without providing a value

benefits/core/models.py

@@ -37,8 +37,6 @@ def __init__(self, *args, **kwargs):
         # although the validator also checks for a max length of 127
         # this setting enforces the length at the database column level as well
         kwargs["max_length"] = 127
-        # similar to max_length, enforce at the field (form) validation level to not allow blanks
-        kwargs["blank"] = False
         # the default is False, but this is more explicit
         kwargs["allow_unicode"] = False
         super().__init__(*args, **kwargs)

tests/pytest/core/test_models.py

@@ -25,6 +25,13 @@ def test_SecretNameField_init():
     assert field.description != ""
 
 
+def test_SecretNameField_init_null_blank():
+    field = SecretNameField(blank=True, null=True)
+
+    assert field.blank is True
+    assert field.null is True
+
+
 @pytest.mark.django_db
 def test_PemData_str(model_PemData):
     assert str(model_PemData) == model_PemData.label