Skip to content

Commit

Permalink
fix(test): remove test that has been revealed to not be meaningful
Browse files Browse the repository at this point in the history
when the fixture was a Mock object, the test saw `uses_auth_verification`
as a function, but now that the fixture is using an actual model object,
the `@property` decorator obscures the function and makes it look like
a `bool` type.

the intent of the test was to ensure the function is called, but that is
already covered by the `bool` being `True` which is already a part of
other tests.
  • Loading branch information
angela-tran committed May 30, 2024
1 parent 2f4ccda commit 1d4eb88
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions tests/pytest/oauth/test_analytics.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,6 @@
from benefits.oauth.analytics import OAuthEvent


@pytest.mark.django_db
def test_OAuthEvent_checks_verifier_uses_auth_verification(app_request, mocked_session_verifier_uses_auth_verification):
mocked_verifier = mocked_session_verifier_uses_auth_verification(app_request)

OAuthEvent(app_request, "event type")

mocked_verifier.uses_auth_verification.assert_called_once


@pytest.mark.django_db
def test_OAuthEvent_verifier_client_name_when_uses_auth_verification(
app_request, mocked_session_verifier_uses_auth_verification
Expand Down

0 comments on commit 1d4eb88

Please sign in to comment.